Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing #3425 and some tests #3430

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (50ec110) 64.76% compared to head (6214c46) 64.73%.

❗ Current head 6214c46 differs from pull request most recent head 293bf1e. Consider uploading reports for the commit 293bf1e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3430      +/-   ##
============================================
- Coverage     64.76%   64.73%   -0.03%     
+ Complexity     4570     4568       -2     
============================================
  Files           274      274              
  Lines         15279    15280       +1     
  Branches        984      983       -1     
============================================
- Hits           9895     9892       -3     
- Misses         4969     4972       +3     
- Partials        415      416       +1     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/BuilderFactory.java 76.14% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 added this to the 5.0.0 milestone May 21, 2023
@sazzad16 sazzad16 merged commit 57eaebf into redis:master May 21, 2023
@sazzad16 sazzad16 deleted the breaking-3425 branch May 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants