Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SORTABLE argument issue in FT.CREATE command #3584

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

sazzad16
Copy link
Collaborator

All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357

All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c7b820a) 67.40% compared to head (e8058ca) 67.37%.

❗ Current head e8058ca differs from pull request most recent head 677e85e. Consider uploading reports for the commit 677e85e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #3584      +/-   ##
============================================
- Coverage     67.40%   67.37%   -0.03%     
+ Complexity     4770     4769       -1     
============================================
  Files           270      270              
  Lines         15357    15357              
  Branches        971      971              
============================================
- Hits          10351    10347       -4     
- Misses         4584     4585       +1     
- Partials        422      425       +3     
Files Coverage Δ
...is/clients/jedis/search/schemafields/TagField.java 47.36% <50.00%> (ø)
...s/clients/jedis/search/schemafields/TextField.java 77.50% <75.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 8d5aa3c into redis:4.x Oct 15, 2023
2 checks passed
@sazzad16 sazzad16 deleted the sortable-arg branch October 15, 2023 13:38
sazzad16 added a commit that referenced this pull request Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
sazzad16 added a commit that referenced this pull request Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
@sazzad16 sazzad16 modified the milestones: 5.1.0, 4.4.x Oct 18, 2023
@sazzad16 sazzad16 modified the milestones: 4.4.x, 4.4.6 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants