Use FTCreateParams for ftCreate method #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do: - Access 'name' of SchemaField
|
@sazzad16 other than missing the SchemaField#name, the changes look good and consistent in Jedis! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
sazzad16
added a commit
to redis/jedis
that referenced
this pull request
Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
sazzad16
added a commit
to redis/jedis
that referenced
this pull request
Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
sazzad16
added a commit
to redis/jedis
that referenced
this pull request
Oct 15, 2023
All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
It has been confirmed by RediSearch developers that it has no effect. It is likely to be residue from older versions.
sazzad16
force-pushed
the
ft-create-params
branch
from
531a936 to
f2fc11b
Compare
|
Cherry-picked on separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: