Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LCS #1924

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Add support for LCS #1924

merged 1 commit into from
Feb 6, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added feature New feature redis-7 labels Feb 2, 2022
@dvora-h dvora-h requested a review from chayim February 2, 2022 11:51
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #1924 (4fe2731) into master (7ea1bf7) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   93.00%   92.98%   -0.03%     
==========================================
  Files          76       76              
  Lines       16500    16520      +20     
==========================================
+ Hits        15346    15361      +15     
- Misses       1154     1159       +5     
Impacted Files Coverage Δ
redis/commands/core.py 90.08% <91.66%> (+<0.01%) ⬆️
tests/test_commands.py 99.39% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 98.16% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea1bf7...4fe2731. Read the comment docs.

@dvora-h dvora-h mentioned this pull request Feb 2, 2022
5 tasks
@dvora-h dvora-h requested a review from chayim February 2, 2022 12:26
@dvora-h dvora-h merged commit b1ffbc9 into redis:master Feb 6, 2022
@dvora-h dvora-h deleted the lcs branch February 6, 2022 13:24
This was referenced Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants