Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LCS #1866

Closed
wants to merge 26 commits into from
Closed

Add support for LCS #1866

wants to merge 26 commits into from

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 6, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1810

@dvora-h dvora-h added feature New feature redis-7 labels Jan 6, 2022
@dvora-h dvora-h requested a review from chayim January 6, 2022 10:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #1866 (6c38e13) into master (15f315a) will decrease coverage by 0.57%.
The diff coverage is 54.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   93.60%   93.03%   -0.58%     
==========================================
  Files          76       76              
  Lines       16214    16446     +232     
==========================================
+ Hits        15177    15300     +123     
- Misses       1037     1146     +109
Impacted Files Coverage Δ
redis/client.py 89.37% <ø> (ø)
redis/cluster.py 92.42% <ø> (+0.37%) ⬆️
redis/commands/graph/commands.py 84.50% <ø> (ø)
redis/ocsp.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
tests/test_ssl.py 48.46% <19.04%> (-5.67%) ⬇️
redis/connection.py 87.02% <37.50%> (-1.31%) ⬇️
tests/test_cluster.py 98.28% <75.00%> (-0.25%) ⬇️
redis/commands/core.py 89.93% <92.85%> (+<0.01%) ⬆️
redis/commands/search/commands.py 89.07% <93.75%> (+0.61%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...6c38e13. Read the comment docs.

chayim
chayim reviewed Jan 12, 2022
View reviewed changes
redis/commands/core.py Outdated
@@ -1866,6 +1866,32 @@ def unlink(self, *names):
"""
return self.execute_command("UNLINK", *names)

def lcs(self, key1, key2, len=False, idx=False, minmatchlen=0, withmatchlen=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add type hints?

chayim
chayim suggested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start getting type hints into our commands...

@dvora-h dvora-h requested a review from chayim January 13, 2022 12:41
tony and others added 21 commits January 25, 2022 16:06
@tony @dvora-h
setup.py: Add project_urls for PyPI (redis#1867)
c0b87ea
@AvitalFineRedis @chayim @dvora-h
FT.CREATE - support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, SKIPINIT…
3dc0e82 
…IALSCAN (redis#1847)

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
@sbv-csis @dvora-h
Allowing poetry and redis-py to install together (redis#1854)
87e17a5 
This moves packaging to >=20.4 rather than the latest.
@Andrew-Chen-Wang @dvora-h
Typo and typing in GraphCommands documentation (redis#1855)
9f11c78
@barshaul @dvora-h
Clusters should optionally require full slot coverage (redis#1845)
71402fe
@Andrew-Chen-Wang @dvora-h
Set keys var otherwise variable not created (redis#1853)
16973fb
@chayim @dvora-h
syncing requirements (redis#1870)
b2fe3cd
@Enchufa2 @dvora-h
get_connection: catch OSError too (redis#1832)
3a9f407
@Andrew-Chen-Wang @dvora-h
Triple quote docstrings in client.py PEP 257 (redis#1876)
3e2f937
@chayim @dvora-h
Timeseries docs fix (redis#1877)
30ca790
@salty-horse @dvora-h
Define incr/decr as aliases of incrby/decrby (redis#1874)
f2fbff8
@chayim @dvora-h
More parallel CI workflows (redis#1881)
c957cc4
@chayim @dvora-h
OCSP Stapling Support (redis#1873)
a10b36d
@jdieter @dvora-h
Add retries to connections in Sentinel Pools (redis#1879)
c928402
@dvora-h
4.1.1 (redis#1883)
7ecf09a
@chayim @dvora-h
direct link to readthedocs (redis#1885)
80645c6
@dvora-h
Add search-json examples (redis#1886)
eff0109
@chayim @dvora-h
Documentation fixes: JSON Example, SSL Connection Examples, RTD versi…
f230622 
…on (redis#1887)
@dvora-h
Fix link in the main page (redis#1897)
fbbb8e3
@soumendrak @dvora-h
README code snippets formatted to highlight properly (redis#1888)
da10d9c
@chayim @dvora-h
redis-unstable cluster docker (redis#1889)
b41f6b7
@chayim
Copy link
Contributor

chayim commented Jan 27, 2022

@dvora-h Can you reseed this or make a new PR on master. 35 changes is... too many.

@dvora-h
Copy link
Collaborator Author

dvora-h commented Feb 2, 2022

Done in #1924

@dvora-h dvora-h closed this Feb 2, 2022
@dvora-h dvora-h deleted the add-lcs branch February 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
feature New feature redis-7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LCS