Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API to improve functionality and usability #1

Merged
merged 2 commits into from
May 24, 2023

Conversation

maRci002
Copy link
Contributor

@maRci002 maRci002 commented Apr 7, 2023

This PR contains the following:

  • Refactored API to use Future instead of promiseToFuture calls
  • createFFmpeg now uses CreateFFmpegParam
  • ffmpeg.run now handles List<String>
  • ffmpeg.runCommand added to use one-liner command
  • ffmpeg.setProgress now requires ProgressParam callback
  • ffmpeg.setLogger now requires LoggerParam callback
  • ffmpeg.unlink added to free up memory
  • ffmpeg.readDir to read files which are handled by ffmpeg
  • Updated documentation
  • Updated example

I have just finished battle testing against the video_editor package

video_editor.mp4

@sarankumar-ns
Copy link
Member

Hi @maRci002, Thank you for your contribution.

@sarankumar-ns sarankumar-ns merged commit 006cafb into redleafsofts:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants