Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud_storage: hold gate in hydration #15697

Merged
merged 1 commit into from
Dec 16, 2023
Merged

cloud_storage: hold gate in hydration #15697

merged 1 commit into from
Dec 16, 2023

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Dec 15, 2023 •
edited by dotnwat
Loading

Most places were already holding the gate external to calls of hydrate() with the exception of aborted_transactions(). This commit fixes this by:

  • holding the gate during aborted_transactions()
  • making hydrate() hold the gate for the duration of its future

Fixes: #15696

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@andrwng
cloud_storage: hold gate in hydration
0aefe35 
Most places were already holding the gate external to calls of
hydrate() with the exception of aborted_transactions(). This commit
fixes this by:
- holding the gate during aborted_transactions()
- making hydrate() hold the gate for the duration of its future
@andrwng andrwng requested review from Lazin, dotnwat and abhijat December 15, 2023 20:33
@andrwng andrwng merged commit 2125f7b into redpanda-data:dev Dec 16, 2023
21 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-15697-v23.2.x-903 remotes/upstream/v23.2.x
git cherry-pick -x 0aefe35edc2d4a693ed23135bc957d01ff1d6319

Workflow run logs.

This was referenced Dec 16, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvartolomei nvartolomei nvartolomei approved these changes

@Lazin Lazin Awaiting requested review from Lazin

@dotnwat dotnwat Awaiting requested review from dotnwat

@abhijat abhijat Awaiting requested review from abhijat

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: remote segment acquires raii gate holder in non-coroutine without capturing it
3 participants
@andrwng @vbotbuildovich @nvartolomei