-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test datalake with recovery mode and disabled partitions #24446
Conversation
/ci-repeat 5 |
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59319#01939901-3ee1-4f93-b9c7-9a656977bebb:
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59319#01939901-3ee0-4d2d-a5fe-3b0edf16105b:
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59319#01939905-17d7-4520-a24f-0ba7df24d931:
non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59319#01939901-3ee2-4b3d-b9a7-4e9a669e9249:
|
Retry command for Build#59319please wait until all jobs are finished before running the slash command
|
Some
Otherwise no errors. |
looks like a merge conflict in application.cc |
2b2a6de
to
80d3ac2
Compare
self.redpanda.restart_nodes( | ||
random.sample(self.redpanda.nodes, 1), | ||
override_cfg_params={"recovery_mode_enabled": True}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe produce to the topic to make it more likely that there's more data that would be scheduled if not for recovery on the given node? And maybe again to "foo" and "bar" after enabling recovery mode for the cluster? At that point, maybe we could also check that the table doesn't grow before and after the sleep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in the next test -- or does recovery mode prevent us from producing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does recovery mode prevent us from producing?
Yes exactly. I thought about adding some checks that the table doesn't grow in recovery mode, but they would be either trivial or inherently flaky.
/backport v24.3.x |
Failed to create a backport PR to v24.3.x branch. I tried:
|
Backports Required
Release Notes
Improvements