-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/buffered_protocol: added a missing call to setup metrics #24553
Merged
mmaslankaprv
merged 3 commits into
redpanda-data:dev
from
mmaslankaprv:buffered-metrics
Dec 17, 2024
Merged
r/buffered_protocol: added a missing call to setup metrics #24553
mmaslankaprv
merged 3 commits into
redpanda-data:dev
from
mmaslankaprv:buffered-metrics
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry command for Build#59670please wait until all jobs are finished before running the slash command
|
CI test resultstest results on build#59670
test results on build#59720
test results on build#59793
|
dotnwat
reviewed
Dec 13, 2024
mmaslankaprv
force-pushed
the
buffered-metrics
branch
from
December 13, 2024 10:22
04aec5e
to
5923ab3
Compare
Retry command for Build#59720please wait until all jobs are finished before running the slash command
|
ztlpn
approved these changes
Dec 13, 2024
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
We already track RPC methods latency so the histogram can be removed. Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
buffered-metrics
branch
from
December 16, 2024 06:38
5923ab3
to
e80fbd6
Compare
Retry command for Build#59793please wait until all jobs are finished before running the slash command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing call to setup
raft::buffered_protocol
metrics.Backports Required
Release Notes