Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/buffered_protocol: added a missing call to setup metrics #24553

Merged
merged 3 commits into from
Dec 17, 2024
Merged

r/buffered_protocol: added a missing call to setup metrics #24553

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aba90af
r/buffered_protocol: added a missing call to setup metrics
mmaslankaprv Dec 12, 2024
710449f
r/buffered_protocol: removed double colons in metric names
mmaslankaprv Dec 13, 2024
e80fbd6
r/buffered_protocol: removed append entries latency histogram
mmaslankaprv Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/v/raft/buffered_protocol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ append_entries_queue::append_entries_queue(
}
_current_max_inflight_requests = new_value;
});
setup_internal_metrics();
// start dispatch loop
ssx::repeat_until_gate_closed(
_gate,
Expand Down Expand Up @@ -357,7 +358,7 @@ void append_entries_queue::setup_internal_metrics() {
}
sm::label_instance target_node_id_label("target_node_id", _target_node);
_internal_metrics.add_group(
prometheus_sanitize::metrics_name("raft::buffered::protocol"),
prometheus_sanitize::metrics_name("raft:buffered:protocol"),
{sm::make_gauge(
"inflight_requests",
[this] { return inflight_requests(); },
Expand All @@ -374,12 +375,7 @@ void append_entries_queue::setup_internal_metrics() {
[this] { return _requests.size(); },
sm::description(
"Total number of append entries requests in the queue"),
{target_node_id_label}),
sm::make_histogram(
"append_entries_request_latency",
sm::description("Latency of append entries requests"),
{target_node_id_label},
[this] { return _hist.internal_histogram_logform(); })});
{target_node_id_label})});
mmaslankaprv marked this conversation as resolved.
Show resolved Hide resolved
}

void append_entries_queue::setup_public_metrics() {
Expand Down
Loading