k/server: Support serialisation for fetch v11 (RackId) #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[KIP-392](https://cwiki.apache.org/confluence/display/KAFKA/KIP-392%3A+Allow+consumers+to+fetch+from+closest+replica) introduces fetch v11 with: * fetch_rquest::rack_id * fetch_response::partition_response::preferred_read_replica For now these are ignored. Tested with librdafka via kafkacat Fixes redpanda-data#883 Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
changed the title
|
thank you for the excellent cover letter! @rkruze is there an easy way to test this with sarama (is that what you mentioned you were using when encountered this?) |
dotnwat
approved these changes
Mar 18, 2021
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Mar 18, 2021
Update Sarama to include: IBM/sarama#1898 "Parsing only known control batches value" `rpk topic consume` now uses fetch v11. Related PR: redpanda-data#890 "k/server: Support serialisation for fetch v11 (RackId)" Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Mar 18, 2021
* Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11. Related PR: redpanda-data#890 "k/server: Support serialisation for fetch v11 (RackId)" Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Mar 18, 2021
Fix `rpk topic consume` * Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890 Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Mar 18, 2021
Fix `rpk topic consume` * Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890 Signed-off-by: Ben Pope <ben@vectorized.io>
BenPope
added a commit
to BenPope/redpanda
that referenced
this pull request
Mar 18, 2021
Fix `rpk topic consume` * Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890 Signed-off-by: Ben Pope <ben@vectorized.io>
|
Now tested with the latest upstream Sarama via rpk: #898 |
joejulian
pushed a commit
to joejulian/redpanda
that referenced
this pull request
Mar 10, 2023
Fix `rpk topic consume` * Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890 Signed-off-by: Ben Pope <ben@vectorized.io>
joejulian
pushed a commit
to joejulian/redpanda
that referenced
this pull request
Mar 24, 2023
Fix `rpk topic consume` * Update Sarama to include: IBM/sarama#1898 * Update mocks `rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890 Signed-off-by: Ben Pope <ben@vectorized.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
KIP-392 introduces fetch v11 with:
fetch_rquest::rack_idfetch_response::partition_response::preferred_read_replicaProvide serialisation support, but for now these are ignored.
Tested with
librdafkaviakafkacat.librdkafka consume seems to now use v11 instead of v4.
Fixes #883
Signed-off-by: Ben Pope ben@vectorized.io
Release notes
Release note: Serialisation support for KIP-392 / Fetch v11.
RackIdandPreferredReadReplicaare currently ignored,