Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk/k8s: Fix consume - update sarama #898

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Mar 18, 2021

Cover letter

Fix rpk topic consume

rpk topic consume now uses fetch v11 implemented in: #890

Signed-off-by: Ben Pope ben@vectorized.io

Release notes

Release note: rpk: Update Sarama to fix rpk topic consume

@BenPope BenPope force-pushed the rpk-update-sarama branch 2 times, most recently from 7f0a067 to d6662bd Compare March 18, 2021 17:06
Fix `rpk topic consume`

* Update Sarama to include: IBM/sarama#1898
* Update mocks

`rpk topic consume` now uses fetch v11 implemented in: redpanda-data#890

Signed-off-by: Ben Pope <ben@vectorized.io>
@BenPope BenPope force-pushed the rpk-update-sarama branch from d6662bd to 578a1fa Compare March 18, 2021 17:09
@BenPope BenPope marked this pull request as ready for review March 18, 2021 17:12
@BenPope BenPope requested a review from dotnwat March 18, 2021 17:13
Copy link
Contributor

@0x5d 0x5d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants