-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: Tailwind setup fails due to latest dep requiring Prettier v3 #9075
Comments
…ier-plugin-tailwindcss v0.5 (#9076) fixes #9075 `prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins the version to `0.4.1`, which is the most recent version prior to v0.5. **NOTE:** This issue will still affect all previous versions of Redwood because the setup ui tailwindcss command defaults to adding the Tailwind deps at latest. ### Next Steps I'll open two PRs, one to revert this and one to upgrade Prettier to v3 (both for next major).
Not sure if this adds to the conversation but I can confirm that today. then ran
and found the error below which is quite similar to #9035.
|
…ier-plugin-tailwindcss v0.5 (#9076) fixes #9075 `prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins the version to `0.4.1`, which is the most recent version prior to v0.5. **NOTE:** This issue will still affect all previous versions of Redwood because the setup ui tailwindcss command defaults to adding the Tailwind deps at latest. ### Next Steps I'll open two PRs, one to revert this and one to upgrade Prettier to v3 (both for next major).
…ier-plugin-tailwindcss v0.5 (#9076) fixes #9075 `prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins the version to `0.4.1`, which is the most recent version prior to v0.5. **NOTE:** This issue will still affect all previous versions of Redwood because the setup ui tailwindcss command defaults to adding the Tailwind deps at latest. ### Next Steps I'll open two PRs, one to revert this and one to upgrade Prettier to v3 (both for next major).
I think there may be some other lint related issues to installing Tailwind. I took the patch and locked in at version 0.4.1 for the tailwind prettier plugin but I also had to install several other deps to get linting to work again. I'm on a Here are the error messages I got: The first 2 were resolved by adding the specified dep to devDeps. The last one required the patch fix from this issue. |
Adding to the above, turns out I had to do one more dependency install to fix the dev server. Seems like this is also needed to resolve dev server issues. I did try reducing down to just the tailwind patch but that wasn't sufficient here. UPDATE: This actually rabbit holed a bit. Doing these changes led to the RW CLI breaking and so I just reverted all the installs and removed the tailwind prettier plugin for now. I'll wait for the next release that fixes this. UPDATE 2: I broke a lot of the references here because my entire setup got borked. Had to revert a good ways to get back to a healthy build. I think there's a combination of issues with tailwind and rw 6.2.0. I kept it to a branch for reference but I need to revert my main branch to get back to a healthy working state. https://github.com/dustinsgoodman/event-platform/commits/broken-state |
I did the following to get back to a stable state for those following along:
All good now. |
This worked for me too in case anyone else runs into the issue, except I am on v6.5. |
I believe this has been resolved. |
What's not working?
See this Forum thread: https://community.redwoodjs.com/t/error-after-setup-tailwind-with-rw-6-0-typescript/5213
^^ Includes a workaround.
What's happening?
The Tailwind dependency
prettier-plugin-tailwindcss
requires Prettier v3 as of version >= 0.5.Prettier v3 was released on July 5th (bummer we missed it for RW v6), and will need to be included in the next Redwood major:
Prettier v3 is now ESM but does support CJS (migration guide in post above).
Next Steps
PR to work around for now is here:
For v7 (next major), here are the PRs to revert current workaround and resolve via Prettier v3 support:
How do we reproduce the bug?
This will fail for any version of Redwood when running the command:
yarn rw setup ui tailwindcsss
The setup command always uses the latest versions of the Tailwind dependencies.
What's your environment? (If it applies)
No response
Are you interested in working on this?
The text was updated successfully, but these errors were encountered: