Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves Tailwind setup command failing due to unsupported prettier-plugin-tailwindcss v0.5 #9076

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

thedavidprice
Copy link
Contributor

@thedavidprice thedavidprice commented Aug 27, 2023

fixes #9075

prettier-plugin-tailwindcss >= 0.5 requires Prettier v3. This PR pins the version to 0.4.1, which is the most recent version prior to v0.5.

NOTE: This issue will still affect all previous versions of Redwood because the setup ui tailwindcss command defaults to adding the Tailwind deps at latest.

Next Steps

I'll open two PRs, one to revert this and one to upgrade Prettier to v3 (both for next major).

@thedavidprice thedavidprice added the release:fix This PR is a fix label Aug 27, 2023
@thedavidprice thedavidprice added this to the next-release-patch milestone Aug 27, 2023
@thedavidprice thedavidprice merged commit c5bdbdb into main Aug 27, 2023
@thedavidprice thedavidprice deleted the dsp-pin-prettier-plugin-tailwindcss@0.4.1 branch August 27, 2023 20:37
@thedavidprice thedavidprice requested a review from jtoar August 27, 2023 20:37
thedavidprice added a commit that referenced this pull request Aug 27, 2023
…ed prettier-plugin-tailwindcss v0.5 (#9076)"

This reverts commit c5bdbdb.
@thedavidprice
Copy link
Contributor Author

@jtoar I got this in and will do final QA on canary package. Please do take a look.

  • update: QA via canary is 👍

Next Steps

These PRs, for the next major v7, will fully resolve this issue:

jtoar pushed a commit that referenced this pull request Sep 2, 2023
…ier-plugin-tailwindcss v0.5 (#9076)

fixes #9075

`prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins
the version to `0.4.1`, which is the most recent version prior to v0.5.

**NOTE:** This issue will still affect all previous versions of Redwood
because the setup ui tailwindcss command defaults to adding the Tailwind
deps at latest.

### Next Steps
I'll open two PRs, one to revert this and one to upgrade Prettier to v3
(both for next major).
@jtoar jtoar modified the milestones: next-release-patch, v6.1.1 Sep 2, 2023
jtoar pushed a commit that referenced this pull request Sep 2, 2023
…ier-plugin-tailwindcss v0.5 (#9076)

fixes #9075

`prettier-plugin-tailwindcss` >= 0.5 requires Prettier v3. This PR pins
the version to `0.4.1`, which is the most recent version prior to v0.5.

**NOTE:** This issue will still affect all previous versions of Redwood
because the setup ui tailwindcss command defaults to adding the Tailwind
deps at latest.

### Next Steps
I'll open two PRs, one to revert this and one to upgrade Prettier to v3
(both for next major).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Tailwind setup fails due to latest dep requiring Prettier v3
2 participants