RSC: Update comments, naming etc based on Danny's input #10104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
changelog-ok
release:chore
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 4, 2024
…sc-build * 'feat/rsc-build' of github.com:dac09/redwood: (32 commits) RSC: ensureProcessDirWeb() (redwoodjs#10108) Comment on ensureProcessDirWeb() Remove redundant cwd check RSC: Extract webpack shims into their own file (redwoodjs#10107) RSC: Remove completed TODO comment RSC: Babel react plugin not needed for analyze phase (redwoodjs#10106) Remove handled TODO RSC: runFeServer: wrap RSC code with `if (rscEnabled)` (redwoodjs#10105) Only comment about swc in one place Remove duplicated comment (exists further down) RSC: Update comments, naming etc based on Danny's input (redwoodjs#10104) RSC: Rename to buildRscClientAndServer (redwoodjs#10103) RSC: Rename to rscBuildForServer, and tweak some comments (redwoodjs#10102) SSR: Extract buildForStreamingServer function (redwoodjs#10099) chore(unit-tests): Silence middleware error logging (redwoodjs#10097) Iterate on `.env` files: make the behavior override (redwoodjs#10094) RSC: smoke-tests: Compare text, not html (redwoodjs#10098) paths.ts: Move helper to esm section More comment formatting getMergedConfig comment format ...
dac09
added a commit
that referenced
this pull request
Mar 6, 2024
…support * 'main' of github.com:redwoodjs/redwood: (30 commits) fix(scenario): Make sure to cleanup even if test fails (#10112) Update babel monorepo to v7.24.0 (#10090) Update storybook monorepo to v7.6.17 (#10089) Update dependency @apollo/client to v3.9.5 (#10087) fix(serve): Allow periods in most paths (#10114) feat(rsc-streaming): Integrating RSC builds with Streaming and Client side hydration (#10031) chore(style): getDefaultViteConfig source format (#10111) chore(refactor): vite - extract default vite config (#10110) chore(comment): cli index FIXME comment about ugly big red box RSC: rscBuildAnalyze: Start at web/src/ (#10109) RSC: ensureProcessDirWeb() (#10108) RSC: Extract webpack shims into their own file (#10107) RSC: Remove completed TODO comment RSC: Babel react plugin not needed for analyze phase (#10106) RSC: runFeServer: wrap RSC code with `if (rscEnabled)` (#10105) RSC: Update comments, naming etc based on Danny's input (#10104) RSC: Rename to buildRscClientAndServer (#10103) RSC: Rename to rscBuildForServer, and tweak some comments (#10102) SSR: Extract buildForStreamingServer function (#10099) chore(unit-tests): Silence middleware error logging (#10097) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other people read the code you've written it becomes much more obvious where the parts that are difficult to understand are, and where more comments are needed, and where the naming doesn't make sense, etc.
This PR addresses some of those areas