fix(serve): Allow periods in most paths #10114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahaywood
pushed a commit
that referenced
this pull request
Mar 5, 2024
dac09
added a commit
that referenced
this pull request
Mar 6, 2024
…support * 'main' of github.com:redwoodjs/redwood: (30 commits) fix(scenario): Make sure to cleanup even if test fails (#10112) Update babel monorepo to v7.24.0 (#10090) Update storybook monorepo to v7.6.17 (#10089) Update dependency @apollo/client to v3.9.5 (#10087) fix(serve): Allow periods in most paths (#10114) feat(rsc-streaming): Integrating RSC builds with Streaming and Client side hydration (#10031) chore(style): getDefaultViteConfig source format (#10111) chore(refactor): vite - extract default vite config (#10110) chore(comment): cli index FIXME comment about ugly big red box RSC: rscBuildAnalyze: Start at web/src/ (#10109) RSC: ensureProcessDirWeb() (#10108) RSC: Extract webpack shims into their own file (#10107) RSC: Remove completed TODO comment RSC: Babel react plugin not needed for analyze phase (#10106) RSC: runFeServer: wrap RSC code with `if (rscEnabled)` (#10105) RSC: Update comments, naming etc based on Danny's input (#10104) RSC: Rename to buildRscClientAndServer (#10103) RSC: Rename to rscBuildForServer, and tweak some comments (#10102) SSR: Extract buildForStreamingServer function (#10099) chore(unit-tests): Silence middleware error logging (#10097) ...
jtoar
pushed a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for route paths with periods in them.
I say "partial", because it doesn't fix it for
yarn rw dev, as that's a Vite bug (vitejs/vite#2415 (comment)). And there's also an edge case foryarn rw servewhere this doesn't fully handle client-side routes that start with/assets/and that also have a last-segment that accepts a period, like/assets/client-route-image.jpgFixes #9969