-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency vite to v5 #10167
Conversation
594cf55
to
e5960a9
Compare
manifest: !env.ssrBuild ? 'client-build-manifest.json' : undefined, | ||
manifest: !env.isSsrBuild ? 'client-build-manifest.json' : undefined, | ||
// Note that sourcemap can be boolean or 'inline' | ||
sourcemap: !env.ssrBuild && rwConfig.web.sourceMap, | ||
sourcemap: !env.isSsrBuild && rwConfig.web.sourceMap, | ||
rollupOptions: { | ||
input: getRollupInput(!!env.ssrBuild), | ||
input: getRollupInput(!!env.isSsrBuild), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the breaking changes; ssrBuild
was renamed to isSsrBuild
. See vitejs/vite#14855
// | ||
// Disable the new warning in Vite v5 about the CJS build being deprecated | ||
// so that users don't have to see it when this command is called with --verbose | ||
process.env.VITE_CJS_IGNORE_WARNING = 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite 5 deprecated the CJS api. The only place the CJS api is used is in a user's vite.config.ts file. We can disable the warning with https://github.com/vitejs/vite/blob/504bc5f80888ebd89d6c6726b18cb6f322ed538f/packages/vite/index.cjs#L29.
legacy: { | ||
// @MARK: for the worker, we're building ESM! (not CJS) | ||
buildSsrCjsExternalHeuristics: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gone in Vite v5; see vitejs/vite#13816
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
It doesn't look like this config is necessary since we're only getting the filenames, and I'm trying to isolate why CI is breaking in #10167 so removing this here to see if it matters.
This PR extracts out the non Vite v5 related changes from #10167. That one is proving difficult (the SSR smoke test keeps failing—`entry.server.mjs` isn't in dist, but `entry.client.mjs` is 🤔) and I don't want some of these changes to have to wait since they're unrelated.
Closing in favor of #10197. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
4.5.2
->5.1.5
Release Notes
vitejs/vite (vite)
v5.1.5
Compare Source
__vite__mapDeps
code injection (#15732) (aff54e1), closes #15732experimentalDecorators: true
(#15206) (4144781), closes #15206pathe
(#16061) (aac2ef7), closes #16061v5.1.4
Compare Source
fs.cachedChecks: true
(#15983) (4fe971f), closes #15983v5.1.3
Compare Source
v5.1.2
Compare Source
isFilePathESM
(#15908) (7b15607), closes #15908v5.1.1
v5.1.0
customLogger
toloadConfigFromFile
(fix #15824) (#15831) (55a3427), closes #15824 #15831vite build --force
(#15837) (f1a4242), closes #15837v5.0.12
Compare Source
Please refer to CHANGELOG.md for details.
v5.0.11
Compare Source
__vite__mapDeps
code before sourcemap file comment (#15483) (d2aa096), closes #15483,
inside base64 value ofsrcset
attribute (#15422) (8de7bd2), closes #15422v5.0.10
Compare Source
v5.0.9
Compare Source
import.meta
correctly for IIFE worker (#15321) (08d093c), closes #15321v5.0.8
Compare Source
v5.0.7
Compare Source
v5.0.6
Compare Source
v5.0.5
Compare Source
vite:preloadError
for chunks without deps (#15203) (d8001c5), closes #15203v5.0.4
Compare Source
v5.0.3
Compare Source
generateCodeFrame
infinite loop (#15093) (6619de7), closes #15093v5.0.2
Compare Source
v5.0.1
v5.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.