feat(vite): upgrade to v5 #10197
Merged
feat(vite): upgrade to v5 #10197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jtoar
force-pushed
the
ds-vite/upgrade-to-v5
branch
from
7fbc0f6 to
9f5d981
Compare
|
The SSR smoke test that's failing is really puzzling. Since it passes the rest of CI, I'm going to merge this and see if it's just because we need a new canary out. If that doesn't work, I'll revert, but I'm a bit out of ideas at the moment. |
This was referenced Mar 11, 2024
jtoar
added a commit
that referenced
this pull request
Mar 11, 2024
jtoar
added a commit
that referenced
this pull request
Mar 12, 2024
jtoar
added
release:breaking
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #10167 since I've split out some of the changes in #10196 and want a cleaner commit history to debug CI.