Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rsc): try fixing dev #10202

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(rsc): try fixing dev #10202

merged 1 commit into from
Mar 11, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 11, 2024

Based on #10201, it looks like CI wasn't correctly catching the errors in the Vite v5 upgrade as far as RSC goes at least. Had some success with configuring this plugin locally.

@jtoar jtoar added the release:fix This PR is a fix label Mar 11, 2024
@jtoar jtoar added this to the RSC milestone Mar 11, 2024
@jtoar jtoar marked this pull request as ready for review March 11, 2024 16:49
@jtoar jtoar added the changesets-ok Override the changesets check label Mar 11, 2024
@jtoar jtoar merged commit edbbf7b into main Mar 11, 2024
44 of 50 checks passed
@jtoar jtoar deleted the ds-rsc/try-fixing-dev branch March 11, 2024 16:56
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants