Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): write vercel.json as a part of setup #10355

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 28, 2024

Follow up to #10295. Implements the strategy suggested in #10295 (comment). Still need to validate with deploy target CI.

@jtoar jtoar added the release:fix This PR is a fix label Mar 28, 2024
@jtoar jtoar added this to the next-release-patch milestone Mar 28, 2024
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I noticed this was in draft? Should we ship it.

@jtoar
Copy link
Contributor Author

jtoar commented Apr 9, 2024

@peterp thanks yeah this one is good!

@jtoar jtoar marked this pull request as ready for review April 9, 2024 16:50
@jtoar jtoar merged commit 18c2d6c into main Apr 9, 2024
46 checks passed
@jtoar jtoar deleted the ds-vercel/fix-corepack-using-build-json branch April 9, 2024 17:10
@jtoar jtoar modified the milestones: next-release-patch, v7.3.1 Apr 9, 2024
jtoar added a commit that referenced this pull request Apr 9, 2024
Follow up to #10295. Implements
the strategy suggested in
#10295 (comment).
Still need to validate with deploy target CI.
jtoar added a commit that referenced this pull request Apr 10, 2024
Quick follow up to #10355. The
value of these env vars have to be strings.
jtoar added a commit that referenced this pull request Apr 10, 2024
Follow up to #10295. Implements
the strategy suggested in
#10295 (comment).
Still need to validate with deploy target CI.
jtoar added a commit that referenced this pull request Apr 10, 2024
Quick follow up to #10355. The
value of these env vars have to be strings.
jtoar added a commit that referenced this pull request Apr 10, 2024
Quick follow up to #10355. The
value of these env vars have to be strings.
jtoar added a commit that referenced this pull request Apr 10, 2024
Follow up to #10295. Implements
the strategy suggested in
#10295 (comment).
Still need to validate with deploy target CI.
jtoar added a commit that referenced this pull request Apr 10, 2024
Quick follow up to #10355. The
value of these env vars have to be strings.
dac09 added a commit that referenced this pull request Apr 11, 2024
…th-mw-auth

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(auth): Handle when authorization header is lowercased (#10442)
  Update rbac.md - code match (#10405)
  chore: make crwa e2e test work across branches (#10437)
  feat: [Auth] Common AuthProvider & use* changes for middleware auth (#10420)
  fix(cli): only show webpack options for dev if `bundler = "webpack"` (#10359)
  fix(vercel): specify build env vars as a string (#10436)
  fix(vercel): write `vercel.json` as a part of setup (#10355)
  fix(middleware): Handle POST requests in middleware router too (#10418)
  chore(ci): get ci running on next (#10432)
  RSC: Explain noExternal vite config option (#10429)
  chore(web): Fix .d.ts overwrite build issue (#10431)
  chore(web): .js imports to prep for ESM (#10430)
  chore(refactor): Split rwjs/forms up into several smaller logical units (#10428)
  chore(rsc): simplify `noExternals` config (#10220)
  chore(deps): Update vite to 5.2.8 (#10427)
  chore(auth): Convert `@redwoodjs/auth` to ESM+CJS dual build (#10417)
  chore(framework-tools): Warn about missing metafile (#10426)
  chore(test): Switch rwjs/auth over to vitest (#10423)
  chore(whatwg-fetch): Switch to importing instead of requiring (#10424)
  chore(deps): bump undici from 5.28.3 to 5.28.4 in /.github/actions/check_changesets (#10421)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants