fix(cli): only show webpack options for dev if bundler = "webpack"
#10359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked with @Tobbe, we're going to just hide these flags instead of remove them to get around this being a breaking change. |
jtoar
force-pushed
the
ds-cli/bundler-dev-options
branch
from
4711212
to
38b5677
Compare
jtoar
added
release:fix
jtoar
added a commit
that referenced
this pull request
Apr 10, 2024
…10359) > This is breaking because it would mean that `yarn rw dev --fwd="..."` would fail instead of no-op like it does now with Vite. (To be clear the current behavior is that it no-ops, as in it doesn't work.) Right now `yarn rw dev --fwd="..."` doesn't work (but doesn't fail) with Vite because it's not wired up. Wiring it up is nontrivial. It's a flag that was used fairly regularly with webpack I think, mostly just to stop the browser from opening. It's been broken since we switched to Vite so a while now, and with no timetable on when it'll be fixed it feels more honest to just not advertise it. We should at least stop showing the other flag which is webpack specific, but yeah.
jtoar
added a commit
that referenced
this pull request
Apr 10, 2024
…10359) > This is breaking because it would mean that `yarn rw dev --fwd="..."` would fail instead of no-op like it does now with Vite. (To be clear the current behavior is that it no-ops, as in it doesn't work.) Right now `yarn rw dev --fwd="..."` doesn't work (but doesn't fail) with Vite because it's not wired up. Wiring it up is nontrivial. It's a flag that was used fairly regularly with webpack I think, mostly just to stop the browser from opening. It's been broken since we switched to Vite so a while now, and with no timetable on when it'll be fixed it feels more honest to just not advertise it. We should at least stop showing the other flag which is webpack specific, but yeah.
jtoar
added a commit
that referenced
this pull request
Apr 10, 2024
…10359) > This is breaking because it would mean that `yarn rw dev --fwd="..."` would fail instead of no-op like it does now with Vite. (To be clear the current behavior is that it no-ops, as in it doesn't work.) Right now `yarn rw dev --fwd="..."` doesn't work (but doesn't fail) with Vite because it's not wired up. Wiring it up is nontrivial. It's a flag that was used fairly regularly with webpack I think, mostly just to stop the browser from opening. It's been broken since we switched to Vite so a while now, and with no timetable on when it'll be fixed it feels more honest to just not advertise it. We should at least stop showing the other flag which is webpack specific, but yeah.
dac09
added a commit
that referenced
this pull request
Apr 11, 2024
…th-mw-auth * 'main' of github.com:redwoodjs/redwood: (21 commits) fix(auth): Handle when authorization header is lowercased (#10442) Update rbac.md - code match (#10405) chore: make crwa e2e test work across branches (#10437) feat: [Auth] Common AuthProvider & use* changes for middleware auth (#10420) fix(cli): only show webpack options for dev if `bundler = "webpack"` (#10359) fix(vercel): specify build env vars as a string (#10436) fix(vercel): write `vercel.json` as a part of setup (#10355) fix(middleware): Handle POST requests in middleware router too (#10418) chore(ci): get ci running on next (#10432) RSC: Explain noExternal vite config option (#10429) chore(web): Fix .d.ts overwrite build issue (#10431) chore(web): .js imports to prep for ESM (#10430) chore(refactor): Split rwjs/forms up into several smaller logical units (#10428) chore(rsc): simplify `noExternals` config (#10220) chore(deps): Update vite to 5.2.8 (#10427) chore(auth): Convert `@redwoodjs/auth` to ESM+CJS dual build (#10417) chore(framework-tools): Warn about missing metafile (#10426) chore(test): Switch rwjs/auth over to vitest (#10423) chore(whatwg-fetch): Switch to importing instead of requiring (#10424) chore(deps): bump undici from 5.28.3 to 5.28.4 in /.github/actions/check_changesets (#10421) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
yarn rw dev --fwd="..."doesn't work (but doesn't fail) with Vite because it's not wired up. Wiring it up is nontrivial. It's a flag that was used fairly regularly with webpack I think, mostly just to stop the browser from opening. It's been broken since we switched to Vite so a while now, and with no timetable on when it'll be fixed it feels more honest to just not advertise it.We should at least stop showing the other flag which is webpack specific, but yeah.