Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing/api): Configure jest to ignore ".scenarios.[jt]s$" files #10945

Closed

Conversation

V1shvesh
Copy link
Contributor

@V1shvesh V1shvesh commented Jul 14, 2024

Solves for #10870

Description:

./api directory structure:
image
./web directory structure:
image

Before:

yarn rw test api:
image

yarn rw test web:
image

After:
yarn rw test api:
image

yarn rw test web:
image

@Tobbe
Copy link
Member

Tobbe commented Jul 16, 2024

Thanks for your PR @V1shvesh
I'd like @cannikin to take a look at this, but he's on vacation right now. I'll ask him to take a look when he's back at work again 🙂

@Tobbe Tobbe requested a review from cannikin July 16, 2024 07:33
@V1shvesh
Copy link
Contributor Author

Thank you for guiding me on the next steps, @Tobbe! I was a bit unsure how to proceed here.

@dthyresson
Copy link
Contributor

@cannikin could you review ? Thanks!

@cannikin
Copy link
Member

Thanks so much @V1shvesh this is great!

Do you think we should do the same thing for *.stories.js and *.mock.js files on the web side? I haven't tried it, but I assume if you put them in a /__tests__ dir then this same behavior will occur!

@cannikin cannikin added the bug/confirmed We have confirmed this is a bug label Jul 22, 2024
@cannikin cannikin added this to the next-release milestone Jul 22, 2024
@cannikin
Copy link
Member

Also, could you add a changeset for this PR? Just run yarn changesets in the root of the repo and it'll generate the file and pre-fill it with the PR description above.

@cannikin cannikin added the release:fix This PR is a fix label Jul 22, 2024
@V1shvesh
Copy link
Contributor Author

V1shvesh commented Jul 27, 2024

Thanks so much @V1shvesh this is great!

Do you think we should do the same thing for *.stories.js and *.mock.js files on the web side? I haven't tried it, but I assume if you put them in a /__tests__ dir then this same behavior will occur!

image

@cannikin confirmed the issue, I can update the PR to include the fix for web/**/__tests__/ files as well.

@V1shvesh
Copy link
Contributor Author

@cannikin creating a new PR with updated branch name + title to capture the updated scope: #11108.
Closing this PR.

@V1shvesh V1shvesh closed this Jul 27, 2024
@Josh-Walker-GM Josh-Walker-GM removed this from the next-release milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants