Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): Configure jest to ignore sidecar files in __tests__ folder #11108

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

V1shvesh
Copy link
Contributor

Solves for #10870

Description:

./api directory structure:
image
./web directory structure:
image

Before:

yarn rw test api:
image

yarn rw test web:
image

After:
yarn rw test api:
image

yarn rw test web:
image

@V1shvesh
Copy link
Contributor Author

@cannikin please have a look, I added config to ignore sidecar files in the web directory as well!

@ahaywood
Copy link
Contributor

Hey @V1shvesh Thanks for taking the time to do this! We'll take a look.

Copy link
Contributor

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @V1shvesh, looks good!

@dac09 dac09 added this to the next-release milestone Jul 30, 2024
@dac09 dac09 added the release:fix This PR is a fix label Jul 30, 2024
@dac09 dac09 enabled auto-merge (squash) July 30, 2024 06:29
@dac09 dac09 disabled auto-merge July 30, 2024 08:01
@cannikin cannikin merged commit 115911d into redwoodjs:main Jul 30, 2024
48 of 54 checks passed
@cannikin
Copy link
Member

Thanks so much for this, works perfectly!

@V1shvesh V1shvesh deleted the feat/jest-ignore-sidecar-files branch August 4, 2024 00:13
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants