Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(esm/cjs): Make dbauth middleware a dual package #10948

Merged
merged 6 commits into from
Jul 17, 2024
Merged

chore(esm/cjs): Make dbauth middleware a dual package #10948

merged 6 commits into from
Jul 17, 2024

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Jul 15, 2024 •
edited
Loading

Outstanding:

  • Excluding dbauth-mw from cjsInterop
  • Generate CTS types the same way as rwjs/vite?

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Jul 15, 2024
@dac09 dac09 added this to the RSC milestone Jul 15, 2024
@dac09
Change how we generate CJS types
75729e5 
Add attw and publint
@dac09 dac09 marked this pull request as ready for review July 16, 2024 08:14
dac09 added 4 commits July 16, 2024 22:58
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into chore/dbauth…
b2794f4 
…-mw-dualpkg

* 'main' of github.com:redwoodjs/redwood:
  RSC: Fix red squiggles in default template (redwoodjs#10955)
  chore(supabase-mw): Convert supabase-mw to dual package (redwoodjs#10954)
  chore(esm/cjs): Make the rwjs/vite package dual (redwoodjs#10934)
  chore(auth): More gracefully handle build failures (redwoodjs#10953)
  fix(web): Re-add generating ESM types (redwoodjs#10952)
  chore(project-config): Verify package.json with publint and attw (redwoodjs#10951)
  chore(apollo client): Add types for cjs imports (redwoodjs#10949)
  chore(tsconfig.types-cjs): Specify tsBuildInfoFile location (redwoodjs#10950)
@dac09
Update build.mts
51bef18
@dac09
Generate cjs types from framework tools
d506c83
@dac09
cjsInterop
340490f
@dac09 dac09 requested a review from Josh-Walker-GM July 17, 2024 04:58
@dac09 Pullflow.com
Copy link
Contributor Author

dac09 commented Jul 17, 2024

🔍 Review requested from Josh-Walker-GM

@dac09
Copy link
Contributor Author

dac09 commented Jul 17, 2024 •
edited
Loading

Just wanted a sanity check @Josh-Walker-GM! I'm merging it in so I can continue on the ESM journey, but please do let me know if you spot anything off.

@dac09 dac09 merged commit 6be62a4 into redwoodjs:main Jul 17, 2024
51 checks passed
@dac09 dac09 deleted the chore/dbauth-mw-dualpkg branch July 17, 2024 05:00
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Awaiting requested review from Josh-Walker-GM

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dac09 @Josh-Walker-GM