Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rsa): Use dist filenames when registering server references #11417

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 3, 2024

Server actions in web/src/... will be built and placed in web/dist/rsc/.... When registering them with React we need to point to the path in dist for prod. In dev, when we can use Vite's ssrLoadModule the rewrite should happen on the fly. But for now we don't support dev, so for now the correct thing to do is to always rewrite

@Tobbe Tobbe added release:fix This PR is a fix changesets-ok Override the changesets check labels Sep 3, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Sep 3, 2024
@Tobbe Tobbe enabled auto-merge (squash) September 4, 2024 07:17
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Sep 4, 2024
@Tobbe Tobbe force-pushed the tobbe-rsa-dist-url branch from 8978de3 to bafab4c Compare September 4, 2024 11:10
@Tobbe Tobbe merged commit 359cb5c into redwoodjs:main Sep 4, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-rsa-dist-url branch September 4, 2024 13:33
@Josh-Walker-GM Josh-Walker-GM added the experimental This PR relates to only experimental feature(s) label Sep 4, 2024
dac09 added a commit to dac09/redwood that referenced this pull request Sep 5, 2024
…-additional-tests

* 'main' of github.com:redwoodjs/redwood:
  chore(rsc): Remove unused methods in the worker (redwoodjs#11431)
  chore(rsc): Simplify worker by not using vite config (redwoodjs#11430)
  Adds section about job errors and failure, backports to versioned 8.0
  chore(publishing): Fix canary publishing for next branch (redwoodjs#11429)
  chore(changesets): Delete old ones post v8 release (redwoodjs#11428)
  fix(rsc): Don't run the Vite dev server in production (redwoodjs#11425)
  fix(rsa): Use dist filenames when registering server references (redwoodjs#11417)
  chore(test-project): Update to postcss 8.4.45 (redwoodjs#11424)
  chore(docs): Compress v7 versions into v7.x (redwoodjs#11422)
  restore workspace:* in package.json files
  Revert "deps(react): 18.3.1 (redwoodjs#10885)"
  v8.0.0
  Version docs to 8.0
  Trigger CI
  deps(react): 18.3.1 (redwoodjs#10885)
  chore(rsa): Add missing routes to test project blog (redwoodjs#11421)
  RSC: Add blog pages to kitchen sink test project (redwoodjs#11420)
  chore(rsc): Refactor: Clean up RSA babel transform (redwoodjs#11415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check experimental This PR relates to only experimental feature(s) fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants