chore(publishing): Fix canary publishing for next branch #11429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:chore
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 4, 2024
You'll see that the canary publishing for the next branch is broken. Example action log: https://github.com/redwoodjs/redwood/actions/runs/10706015686/job/29682729719 The problem as I see it is that we're grep'ing for `-canary.` but in this case we're looking to publish with the `-next.` prefix which is clearly the one output by lerna. This PR updates the grep to use a regex for either the next or canary match.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Sep 5, 2024
…-additional-tests * 'main' of github.com:redwoodjs/redwood: chore(rsc): Remove unused methods in the worker (redwoodjs#11431) chore(rsc): Simplify worker by not using vite config (redwoodjs#11430) Adds section about job errors and failure, backports to versioned 8.0 chore(publishing): Fix canary publishing for next branch (redwoodjs#11429) chore(changesets): Delete old ones post v8 release (redwoodjs#11428) fix(rsc): Don't run the Vite dev server in production (redwoodjs#11425) fix(rsa): Use dist filenames when registering server references (redwoodjs#11417) chore(test-project): Update to postcss 8.4.45 (redwoodjs#11424) chore(docs): Compress v7 versions into v7.x (redwoodjs#11422) restore workspace:* in package.json files Revert "deps(react): 18.3.1 (redwoodjs#10885)" v8.0.0 Version docs to 8.0 Trigger CI deps(react): 18.3.1 (redwoodjs#10885) chore(rsa): Add missing routes to test project blog (redwoodjs#11421) RSC: Add blog pages to kitchen sink test project (redwoodjs#11420) chore(rsc): Refactor: Clean up RSA babel transform (redwoodjs#11415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll see that the canary publishing for the next branch is broken. Example action log: https://github.com/redwoodjs/redwood/actions/runs/10706015686/job/29682729719
The problem as I see it is that we're grep'ing for
-canary.but in this case we're looking to publish with the-next.prefix which is clearly the one output by lerna. This PR updates the grep to use a regex for either the next or canary match.This is going to ultimately be a "merge it and find out" sort of fix.