Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct env filename on serverless firstrun deploy #6023

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Show correct env filename on serverless firstrun deploy #6023

merged 3 commits into from
Jul 25, 2022

Conversation

joconor
Copy link
Contributor

@joconor joconor commented Jul 22, 2022

RedwoodJS uses the .env.{stage} file to link the front-end deployment to the back-end. Different Serverless stages use different files to keep separate deployments separate. However, when doing a --first-run deployment which creates the .env.{stage} file, the message that asks permission to create the file only references a hard-coded .env.production filename. It should display the correct filename that reflects the serverless stage being deployed to.

@nx-cloud
Copy link

nx-cloud bot commented Jul 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19d9eee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 22, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 19d9eee
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62de59013592a3000883d952

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're quite right @joconor, thank you for the fix!

@jtoar jtoar added topic/cli release:fix This PR is a fix labels Jul 25, 2022
@jtoar jtoar enabled auto-merge (squash) July 25, 2022 09:04
@jtoar jtoar merged commit e5d350b into redwoodjs:main Jul 25, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jul 25, 2022
@jtoar jtoar modified the milestones: next-release, v2.1.1 Jul 25, 2022
dac09 added a commit to dthyresson/redwood that referenced this pull request Jul 28, 2022
…onfig-plugins

* 'main' of github.com:redwoodjs/redwood: (78 commits)
  fix(cli): Modify existence check of jest.config to check for both .js and .ts extensions in rw test (redwoodjs#6074)
  Tutorial 6.4: Add type generics to mockGraphQLMutation (redwoodjs#6046)
  Tutorial 6.2: Add generics type hint to CellSuccessProps (redwoodjs#6042)
  fix(deps): update graphql-tools monorepo (redwoodjs#6066)
  fix(deps): update dependency @types/node to v16.11.46 (redwoodjs#6065)
  chore(deps): update dependency @okta/okta-auth-js to v6.7.3 (redwoodjs#6068)
  chore(deps): update dependency @types/react to v17.0.48 (redwoodjs#6069)
  CLI responsiveness (redwoodjs#6028)
  Copy changes from "Make Jest Debugging a No-Brainer" (5296) (redwoodjs#6070)
  fix(deps): update dependency @graphql-codegen/cli to v2.11.0 (redwoodjs#6067)
  Update yarn.lock
  Version docs to 2.2
  Update all contributors
  Update yarn.lock
  v2.2.0
  Dedupe yarn.lock
  Show correct env filename on serverless firstrun deploy (redwoodjs#6023)
  chore(deps): update dependency firebase to v9.9.1 (redwoodjs#6020)
  tailwindcss ui: Add tailwindcss prettier rules (redwoodjs#5812)
  fix(deps): update dependency eslint-plugin-jsx-a11y to v6.6.1 (redwoodjs#6017)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix topic/cli
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

3 participants