Tutorial 6.2: Add generics type hint to CellSuccessProps #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves intellisense, enhancing the passed resultset from `any` to its actual query return type.
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 86a2189. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dac09
approved these changes
Jul 28, 2022
|
Thanks @Philzen! 🚀 |
dac09
added a commit
to dthyresson/redwood
that referenced
this pull request
Jul 28, 2022
…onfig-plugins * 'main' of github.com:redwoodjs/redwood: (78 commits) fix(cli): Modify existence check of jest.config to check for both .js and .ts extensions in rw test (redwoodjs#6074) Tutorial 6.4: Add type generics to mockGraphQLMutation (redwoodjs#6046) Tutorial 6.2: Add generics type hint to CellSuccessProps (redwoodjs#6042) fix(deps): update graphql-tools monorepo (redwoodjs#6066) fix(deps): update dependency @types/node to v16.11.46 (redwoodjs#6065) chore(deps): update dependency @okta/okta-auth-js to v6.7.3 (redwoodjs#6068) chore(deps): update dependency @types/react to v17.0.48 (redwoodjs#6069) CLI responsiveness (redwoodjs#6028) Copy changes from "Make Jest Debugging a No-Brainer" (5296) (redwoodjs#6070) fix(deps): update dependency @graphql-codegen/cli to v2.11.0 (redwoodjs#6067) Update yarn.lock Version docs to 2.2 Update all contributors Update yarn.lock v2.2.0 Dedupe yarn.lock Show correct env filename on serverless firstrun deploy (redwoodjs#6023) chore(deps): update dependency firebase to v9.9.1 (redwoodjs#6020) tailwindcss ui: Add tailwindcss prettier rules (redwoodjs#5812) fix(deps): update dependency eslint-plugin-jsx-a11y to v6.6.1 (redwoodjs#6017) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves intellisense, enhancing the passed resultset from
anyto its actual query return type.I just rechecked – this is actually the default that's being generated with
yarn rw g cell Comment– even without the SDL in place yet, so this may have been simply forgotten when TS tabs were added to the tutorial.