Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Deploy: Define plan in template #6905

Merged
merged 5 commits into from
Nov 28, 2022

Conversation

tomjdickson
Copy link
Contributor

Motivation & Description

Recently set up a hobby project learning redwood & deployed it to Render. Render defaults the service plan to starter. Have added the plan to the default template and defined it as free, allowing developers to otherwise define it at a glance if required.

Assuming this is something developers would prefer.

Highlevel Changes

  • Altered Render Yaml template.
  • Reviewed docs, there is not current reference to plan, so I haven't changed it.

@jtoar jtoar added release:fix This PR is a fix fixture-ok Override the test project fixture check labels Nov 16, 2022
@jtoar jtoar self-assigned this Nov 16, 2022
@jtoar
Copy link
Contributor

jtoar commented Nov 16, 2022

Hey @tomjdickson this makes sense to me; let me get confirmation with a few others.

@jtoar jtoar enabled auto-merge (squash) November 28, 2022 14:48
@jtoar jtoar merged commit 4d5cbdf into redwoodjs:main Nov 28, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Nov 28, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Nov 28, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

dac09 added a commit that referenced this pull request Nov 29, 2022
…xperimental-vite-optin

* 'main' of github.com:redwoodjs/redwood:
  fix(deps): update dependency css-loader to v6.7.2 (#6976)
  auth0 and netlify auth packages (#6922)
  fix(deps): update graphqlcodegenerator monorepo (#6980)
  fix(deps): update dependency react-hook-form to v7.39.7 (#6978)
  fix(deps): update dependency fastify-raw-body to v4.1.3 (#6977)
  chore(deps): update dependency esbuild to v0.15.16 (#6975)
  chore(deps): update babel monorepo (#6974)
  Make it clearer that can use directiveArgs in transformer directive (#6497)
  docs: Adds Troubleshooting Section to Serverless (#6498)
  fix: extractCookie from GraphiQLHeader (#6894) (#6969)
  Render Deploy: Define plan in template (#6905)
  fix launch.json (#6972)
  small tweak to flightcontrol deploy docs (#6973)
@jtoar jtoar modified the milestones: next-release, v4.0.0 Dec 8, 2022
jtoar pushed a commit that referenced this pull request Dec 8, 2022
@jtoar jtoar modified the milestones: v4.0.0, next-release, v3.7.0, next-release-patch, v3.6.1 Dec 8, 2022
@jtoar jtoar modified the milestones: next-release-patch, v3.6.1 Dec 9, 2022
jtoar pushed a commit that referenced this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants