fix launch.json #6972
Merged
fix launch.json #6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Thanks @adriatic, I can reproduce this, and after some searching through VS Code issues I found that protocol has been deprecated per microsoft/vscode#152479 and "stopOnEntry": false is incompatible with "request": "attach"
|
Thanks for this confirmation @jtoar. My PR is the consequence of my
revived interest I finally writing the debugging articles
<https://rw-community.org/app%20management/debugging/introduction> I
promised an eon ago. The current technology improvements by Google and
Microsoft made it obvious that I need to document these.
I care a lot about your desire to know as much about anything Redwood*
as possible
Nik
…------ Original Message ------
From "Dominic Saadi" ***@***.***>
To "redwoodjs/redwood" ***@***.***>
Cc "Nikolaj Ivancic" ***@***.***>; "Mention"
***@***.***>
Date 11/28/2022 9:41:51 AM
Subject Re: [redwoodjs/redwood] fix launch.json (PR #6972)
@jtoar approved this pull request.
Thanks @adriatic <https://github.com/adriatic>, I can reproduce this,
and after some searching through VS Code issues I found that protocol
has been deprecated per microsoft/vscode#152479
<microsoft/vscode#152479> and "stopOnEntry":
false is incompatible with "request": "attach"
—
Reply to this email directly, view it on GitHub
<#6972 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUWGVOD74YJXBFHE2FAQ7LWKTAC7ANCNFSM6AAAAAASM3BLEA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dac09
added a commit
that referenced
this pull request
Nov 29, 2022
…xperimental-vite-optin * 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency css-loader to v6.7.2 (#6976) auth0 and netlify auth packages (#6922) fix(deps): update graphqlcodegenerator monorepo (#6980) fix(deps): update dependency react-hook-form to v7.39.7 (#6978) fix(deps): update dependency fastify-raw-body to v4.1.3 (#6977) chore(deps): update dependency esbuild to v0.15.16 (#6975) chore(deps): update babel monorepo (#6974) Make it clearer that can use directiveArgs in transformer directive (#6497) docs: Adds Troubleshooting Section to Serverless (#6498) fix: extractCookie from GraphiQLHeader (#6894) (#6969) Render Deploy: Define plan in template (#6905) fix launch.json (#6972) small tweak to flightcontrol deploy docs (#6973)
jtoar
added a commit
that referenced
this pull request
Dec 8, 2022
* fix launch.json * chore: update test project fixture Co-authored-by: nik <nik@Nikolajs-MacBook-Pro.local> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar
added a commit
that referenced
this pull request
Dec 10, 2022
* fix launch.json * chore: update test project fixture Co-authored-by: nik <nik@Nikolajs-MacBook-Pro.local> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several different files
launch.json- PR addresses the likely most often used one athttps://github.com/redwoodjs/redwood/blob/main/packages/create-redwood-app/template/.vscode/launch.json.I am proposing to remove two arguments
The first one is illegal in the context it is being used and the second one's default value is false, so it is redundant.
I presented this issue in Discourse hoping to elicit some comments, go nothing so far