Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7482/validators exclude include caseinsensitive #7573

Merged
merged 10 commits into from
Feb 15, 2023
Merged

7482/validators exclude include caseinsensitive #7573

merged 10 commits into from
Feb 15, 2023

Conversation

taivo
Copy link
Contributor

@taivo taivo commented Feb 6, 2023

No description provided.

@taivo taivo mentioned this pull request Feb 6, 2023
Closed
1 task
@replay-io
Copy link

replay-io bot commented Feb 6, 2023 •
edited
Loading

16 replays were recorded for 7fcc3de.

image 0 Failed
image 16 Passed

View test run on Replay ↗︎

@jtoar jtoar added the release:feature This PR introduces a new feature label Feb 8, 2023
@jtoar jtoar self-requested a review February 8, 2023 04:15
jtoar
jtoar approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @cannikin if you could have a look that'd be great; @taivo was specifically wondering about the helper function, if it could be organized a different way. (But if you don't mind then all good)

cannikin
cannikin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@cannikin cannikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this!

@jtoar we should probably update the docs? Or is that in a separate PR?

@jtoar
Copy link
Contributor

jtoar commented Feb 14, 2023

@cannikin ah yeah we should, @taivo would you be up for doing that in this PR as well?

@taivo
Copy link
Contributor Author

taivo commented Feb 15, 2023

@jtoar done!

@jtoar jtoar merged commit 1540507 into redwoodjs:main Feb 15, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 15, 2023
jtoar pushed a commit that referenced this pull request Feb 16, 2023
@taivo @jtoar
7482/validators exclude include caseinsensitive (#7573)
3603492 
* fixed exclusion and inclusion types to accept Array

* fix 'format' validator types to accept RegExp as expected in unit tests

* remove excess parens to make sure both regexp test cases are run

* validations: add 'caseSensitive' boolean option to exclusion and inclusion

* incluse caseSensitive option in service validation docs
jtoar pushed a commit that referenced this pull request Feb 16, 2023
@taivo @jtoar
7482/validators exclude include caseinsensitive (#7573)
f54cb84 
* fixed exclusion and inclusion types to accept Array

* fix 'format' validator types to accept RegExp as expected in unit tests

* remove excess parens to make sure both regexp test cases are run

* validations: add 'caseSensitive' boolean option to exclusion and inclusion

* incluse caseSensitive option in service validation docs
@jtoar jtoar modified the milestones: next-release, v4.2.0 Feb 16, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Feb 21, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/vite-ssr
4796caf 
* 'main' of github.com:redwoodjs/redwood: (33 commits)
  chore(deps): update dependency lerna to v6.5.1 (redwoodjs#7631)
  Get rid of red squiggles in new lambda functions (redwoodjs#7640)
  chore: add redirects for compressed v2, v3 docs
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.3 (redwoodjs#7645)
  chore(deps): update dependency @types/react-dom to v18.0.11 (redwoodjs#7644)
  7482/validators exclude include caseinsensitive (redwoodjs#7573)
  chore(deps): update dependency @clerk/clerk-react to v4.11.3 (redwoodjs#7642)
  chore(deps): update dependency @replayio/playwright to v0.3.21 (redwoodjs#7643)
  chore(deps): update dependency supertokens-auth-react to v0.31.1 (redwoodjs#7628)
  chore(deps): update dependency @types/vscode to v1.75.1 (redwoodjs#7630)
  fix:(webAuthn) use `globalThis`, not `process.env` (redwoodjs#7639)
  feat(api): support building .jsx, .tsx files (redwoodjs#7638)
  chore(CI): CI telemetry checking (redwoodjs#7623)
  chore(deps): update dependency supertokens-node to v13.0.2 (redwoodjs#7629)
  fix(docs): typo in `GraphQL` docs (redwoodjs#7634)
  fix(ts): Undo skipLibCheck change (redwoodjs#7633)
  fix(generator): add dotAll to Router regex (redwoodjs#7605)
  chore(deps): update dependency @clerk/types to v3.27.0 (redwoodjs#7614)
  fix(deps): update dependency eslint to v8.34.0 (redwoodjs#7615)
  fix(deps): update dependency systeminformation to v5.17.9 (redwoodjs#7622)
  ...
jtoar added a commit that referenced this pull request Feb 21, 2023
@jtoar
chore: remove resolutions
9ef7381 
I had to do this to get @redwoodjs/api to build after cherry picking 1540507 (7482/validators exclude include caseinsensitive, #7573)
jtoar added a commit that referenced this pull request Feb 22, 2023
@jtoar
chore: remove resolutions
aa718e0 
I had to do this to get @redwoodjs/api to build after cherry picking 1540507 (7482/validators exclude include caseinsensitive, #7573)
jtoar added a commit that referenced this pull request Feb 22, 2023
@jtoar
chore: remove resolutions
95d0941 
I had to do this to get @redwoodjs/api to build after cherry picking 1540507 (7482/validators exclude include caseinsensitive, #7573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

@cannikin cannikin cannikin approved these changes

Assignees
No one assigned
Labels
release:feature This PR introduces a new feature
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@taivo @jtoar @cannikin