Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): CI telemetry checking #7623

Merged
merged 10 commits into from
Feb 14, 2023
Merged

chore(CI): CI telemetry checking #7623

merged 10 commits into from
Feb 14, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Feb 11, 2023

Problem
We have no way of checking at the CI level that PRs are not breaking the telemetry setup.

Changes

  1. Adds a CI check which executes both the CRWA and the CLI scripts and listens for telemetry which is redirected to localhost instead of telemetry.redwoodjs.com.
  2. Adds an env var REDWOOD_REDIRECT_TELEMETRY which overrides the default telemetry endpoint of telemetry.redwoodjs.com when set. Needed because it is too complex to try and run a https listener on port 80 within the CI.

Outstanding

  1. Need to let the telemetry fix go in first.
  2. Decide if we should add the bundler flag? I think so. I added it in.

Ping
@thedavidprice

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Feb 11, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar February 13, 2023 12:40
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Josh-Walker-GM! Left a few comments, but not much left to do otherwise. Also I'm going to push up a commit that just runs yarn lint on this new file. (The actual command is slightly more complicated than that since eslint ignores dot directories.)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/actions/telemetry_check_crwa/action.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@thedavidprice
Copy link
Contributor

Nice! 🚀

@Josh-Walker-GM
Copy link
Collaborator Author

Josh-Walker-GM commented Feb 14, 2023

Okay @jtoar I think I've addressed your concerns about the hard coded host/port. I've also added in the corresponding check for telemetry from the CLI. Hope that running yarn install within the check won't introduce any issues?

Can you apply some of your linting secret sauce again please?

@Josh-Walker-GM Josh-Walker-GM changed the title chore(telemetry): CI for telemetry with CRWA chore(CI): CI telemetry checking Feb 14, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn install won't matter, let's merge it

@jtoar jtoar merged commit ffb933d into main Feb 14, 2023
@jtoar jtoar deleted the jgmw-telemetry-ci branch February 14, 2023 19:52
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 14, 2023
jtoar pushed a commit that referenced this pull request Feb 14, 2023
* telemetry ci which listens for redirected telemetry packets from crwa

* chore: run lint and formatting changes

* refactor and test the cli too

* restore build emoji change

* fix field bundler to webBundler

* attempt to fix directory

* chore: lint fix
@jtoar jtoar modified the milestones: next-release, v4.2.0 Feb 14, 2023
jtoar pushed a commit that referenced this pull request Feb 14, 2023
* telemetry ci which listens for redirected telemetry packets from crwa

* chore: run lint and formatting changes

* refactor and test the cli too

* restore build emoji change

* fix field bundler to webBundler

* attempt to fix directory

* chore: lint fix
dac09 added a commit to dac09/redwood that referenced this pull request Feb 21, 2023
* 'main' of github.com:redwoodjs/redwood: (33 commits)
  chore(deps): update dependency lerna to v6.5.1 (redwoodjs#7631)
  Get rid of red squiggles in new lambda functions (redwoodjs#7640)
  chore: add redirects for compressed v2, v3 docs
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.3 (redwoodjs#7645)
  chore(deps): update dependency @types/react-dom to v18.0.11 (redwoodjs#7644)
  7482/validators exclude include caseinsensitive (redwoodjs#7573)
  chore(deps): update dependency @clerk/clerk-react to v4.11.3 (redwoodjs#7642)
  chore(deps): update dependency @replayio/playwright to v0.3.21 (redwoodjs#7643)
  chore(deps): update dependency supertokens-auth-react to v0.31.1 (redwoodjs#7628)
  chore(deps): update dependency @types/vscode to v1.75.1 (redwoodjs#7630)
  fix:(webAuthn) use `globalThis`, not `process.env` (redwoodjs#7639)
  feat(api): support building .jsx, .tsx files (redwoodjs#7638)
  chore(CI): CI telemetry checking (redwoodjs#7623)
  chore(deps): update dependency supertokens-node to v13.0.2 (redwoodjs#7629)
  fix(docs): typo in `GraphQL` docs (redwoodjs#7634)
  fix(ts): Undo skipLibCheck change (redwoodjs#7633)
  fix(generator): add dotAll to Router regex (redwoodjs#7605)
  chore(deps): update dependency @clerk/types to v3.27.0 (redwoodjs#7614)
  fix(deps): update dependency eslint to v8.34.0 (redwoodjs#7615)
  fix(deps): update dependency systeminformation to v5.17.9 (redwoodjs#7622)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants