Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the Node.js build target to 18 LTS #8106

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 25, 2023

This PR bumps the Node.js build target for all the @redwoodjs/ packages and a Redwood project's api side to 18 LTS.

The 16 LTS has a shorter lifespan than the others because of the OpenSSL release cycle. It's still a ways away from being defunct, but now that all Redwood's deploy providers support 18, there's no reason not to move on. You can read more about the Node.js 16 LTS here: https://nodejs.org/en/blog/announcements/nodejs16-eol.

After this PR, we'll only be testing one Node.js version in CI.

@jtoar jtoar added the release:breaking This PR is a breaking change label Apr 25, 2023
@jtoar jtoar force-pushed the ds-build-target/bump-to-node-18 branch from f8645c5 to 81fd851 Compare April 25, 2023 05:02
@replay-io
Copy link

replay-io bot commented Apr 25, 2023

16 replays were recorded for 7b17896.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/ab28f6e4-1818-48bc-a7b8-a9d88e5aea8b>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/2088dab3-c4d2-455e-80f5-4e6a81154e95>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/c8d5604b-b970-4053-aea6-ac04957884ff>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/172c04da-6e20-4f6f-a195-174d738fd01c>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/47a997f7-364c-412c-b413-f48e0bc697bd>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/ba537dfe-e14f-430b-bccf-7840def69777>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/34b32cfd-adad-492a-8986-c42be083172a>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/ab4ad8a2-dfcc-46ef-943b-99f07cafd6d3>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/b2417cd4-47a1-4e2a-ad34-e056c732d5d8>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/5ad66f20-8f1e-42df-aa79-616cb5a6b502>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/7420ef0a-3051-4d11-a201-dba5dc3dbf24>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/8496a224-72fa-453c-ae9e-b6d73e70e120>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/8db73081-93c5-4acb-96af-d24138b5bf56>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/e649a6f4-d7ff-4ed3-a490-29d93e4cc634>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/1ea9422d-0078-4dc1-9b86-d983fc3da0cf>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

1 similar comment
@replay-io
Copy link

replay-io bot commented Apr 25, 2023

16 replays were recorded for 7b17896.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/ab28f6e4-1818-48bc-a7b8-a9d88e5aea8b>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/2088dab3-c4d2-455e-80f5-4e6a81154e95>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/c8d5604b-b970-4053-aea6-ac04957884ff>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/172c04da-6e20-4f6f-a195-174d738fd01c>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/47a997f7-364c-412c-b413-f48e0bc697bd>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/ba537dfe-e14f-430b-bccf-7840def69777>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/34b32cfd-adad-492a-8986-c42be083172a>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/ab4ad8a2-dfcc-46ef-943b-99f07cafd6d3>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/b2417cd4-47a1-4e2a-ad34-e056c732d5d8>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/5ad66f20-8f1e-42df-aa79-616cb5a6b502>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/7420ef0a-3051-4d11-a201-dba5dc3dbf24>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/8496a224-72fa-453c-ae9e-b6d73e70e120>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/8db73081-93c5-4acb-96af-d24138b5bf56>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/e649a6f4-d7ff-4ed3-a490-29d93e4cc634>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/1ea9422d-0078-4dc1-9b86-d983fc3da0cf>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar merged commit 563a0f2 into main Apr 25, 2023
@jtoar jtoar deleted the ds-build-target/bump-to-node-18 branch April 25, 2023 16:10
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 25, 2023
@jtoar jtoar modified the milestones: next-release, v5.0.0 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant