-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the Node.js build target to 18 LTS #8106
Merged
Merged
+31
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-build-target/bump-to-node-18
branch
from
April 25, 2023 05:02
f8645c5
to
81fd851
Compare
16 replays were recorded for 7b17896. 16 PassedrequireAuth graphql checks
|
1 similar comment
16 replays were recorded for 7b17896. 16 PassedrequireAuth graphql checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Node.js build target for all the
@redwoodjs/
packages and a Redwood project's api side to 18 LTS.The 16 LTS has a shorter lifespan than the others because of the OpenSSL release cycle. It's still a ways away from being defunct, but now that all Redwood's deploy providers support 18, there's no reason not to move on. You can read more about the Node.js 16 LTS here: https://nodejs.org/en/blog/announcements/nodejs16-eol.
After this PR, we'll only be testing one Node.js version in CI.