Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): make @redwoodjs/cli-data-migrate package size smaller #9085

Merged
merged 12 commits into from
Aug 31, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Aug 29, 2023

Follow up to #8572. Even if I remove @redwoodjs/babel-config's dependency on @redwoodjs/structure, both @redwoodjs/cli-helpers and @redwoodjs/telemetry depend on it. I have to choose my battles here, so it feels like we should just remove cli-helpers and telemetry from this cli-data-migrate for now.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Aug 29, 2023
@jtoar jtoar added this to the next-release milestone Aug 29, 2023
@jtoar jtoar marked this pull request as ready for review August 30, 2023 23:27
@jtoar jtoar enabled auto-merge (squash) August 31, 2023 00:34
@jtoar jtoar merged commit 2cc76e6 into main Aug 31, 2023
@jtoar jtoar deleted the ds-cli-plugins/optimize-data-migrate branch August 31, 2023 01:01
@thedavidprice
Copy link
Contributor

Nice work on this @jtoar 🚀

I have a few questions. Will follow up directly.

jtoar added a commit that referenced this pull request Sep 2, 2023
…9085)

Follow up to #8572. Even if I
remove `@redwoodjs/babel-config`'s dependency on `@redwoodjs/structure`,
both `@redwoodjs/cli-helpers` and `@redwoodjs/telemetry` depend on it. I
have to choose my battles here, so it feels like we should just remove
cli-helpers and telemetry from this cli-data-migrate for now.
@jtoar jtoar modified the milestones: next-release, v6.2.0 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants