-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation on mocking useParams in component test #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinsgoodman
force-pushed
the
patch-1
branch
2 times, most recently
from
October 10, 2023 00:17
82aa501
to
685b89e
Compare
dustinsgoodman
force-pushed
the
patch-1
branch
from
October 10, 2023 00:19
685b89e
to
313d36c
Compare
dac09
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dustinsgoodman, and sorry it ttook so long to review. Completely missed your PR :)
No worries! Thanks @dac09! |
jtoar
pushed a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Dec 1, 2023
…ath-aliases * 'main' of github.com:redwoodjs/redwood: (23 commits) Add note about base 64 encoded event body (redwoodjs#9595) fix(deps): update graphql-tools monorepo (redwoodjs#9609) fix(deps): update dependency fs-extra to v11.2.0 (redwoodjs#9606) fix(deps): update dependency graphql-sse to v2.4.0 (redwoodjs#9607) fix(deps): update docusaurus monorepo to v3.0.1 (redwoodjs#9608) fix(deps): update babel monorepo (redwoodjs#9596) fix(deps): update dependency @whatwg-node/server to v0.9.18 (redwoodjs#9602) fix(deps): update dependency @apollo/client to v3.8.8 (redwoodjs#9600) chore: update yarn.lock chore(deps): update dependency @playwright/test to v1.40.1 (redwoodjs#9599) chore(deps): update dependency @supabase/supabase-js to v2.39.0 (redwoodjs#9603) fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (redwoodjs#9601) chore(deps): update dependency @clerk/clerk-react to v4.28.1 (redwoodjs#9598) fix(deps): update storybook monorepo to v7.6.2 (redwoodjs#9597) RSC: Generate a route manifest (redwoodjs#9592) chore(private-set): Wrap profile page in <PrivateSet> instead of Private (redwoodjs#9575) add documentation on mocking useParams in component test (redwoodjs#9284) Update Typescript to 5.3.2 (redwoodjs#9589) RSC: Refactor build process (redwoodjs#9588) fix(crwa): clarify docs to avoid issues in yarn modern installs (redwoodjs#9579) ...
dac09
added a commit
that referenced
this pull request
Jan 22, 2024
…nario-multiple-tests * 'main' of github.com:redwoodjs/redwood: (21 commits) fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602) fix(deps): update dependency @apollo/client to v3.8.8 (#9600) chore: update yarn.lock chore(deps): update dependency @playwright/test to v1.40.1 (#9599) chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603) fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601) chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598) fix(deps): update storybook monorepo to v7.6.2 (#9597) RSC: Generate a route manifest (#9592) chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575) add documentation on mocking useParams in component test (#9284) Update Typescript to 5.3.2 (#9589) RSC: Refactor build process (#9588) fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579) fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582) fix: Remove "god code" typos from auth READMEs (#9583) Experimental Dockerfile: Fix typo in setup command (#9577) fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558) 9316/update mantine setup (#9388) chore: clean up `RouteParams` type test structure (#9573) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a conversation in Discord with Danny and we realized the docs didn't explain how to mock
useParams
and that the API was obscure. This adds docs based on intended use. https://discord.com/channels/679514959968993311/1142813226153820181/1159941147830009906