Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(private-set): Wrap profile page in <PrivateSet> instead of Private #9575

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

DonsWayo
Copy link
Contributor

@DonsWayo DonsWayo commented Nov 25, 2023

Private and Set private was deprecated in v6.4.x - this PR changes the docs to use <PrivateSet> instead and updates some test fixtures.

@DonsWayo DonsWayo changed the title Wrap profile page in <PrivateSet> instead of chore(DOCS): Wrap profile page in <PrivateSet> instead of Private Nov 25, 2023
@dac09 dac09 self-assigned this Nov 29, 2023
@dac09 dac09 added the release:docs This PR only updates docs label Nov 29, 2023
@dac09 dac09 added this to the next-release-patch milestone Nov 29, 2023
Copy link
Contributor

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DonsWayo - thanks for the PR!

@dac09 dac09 enabled auto-merge (squash) November 29, 2023 09:08
auto-merge was automatically disabled November 29, 2023 09:52

Head branch was pushed to by a user without write access

@DonsWayo
Copy link
Contributor Author

@dac09 thanks!, I see in the CI lint an error with the unused and missing import, I add this change to avoid failing the job.

@dac09 dac09 changed the title chore(DOCS): Wrap profile page in <PrivateSet> instead of Private chore(private-set): Wrap profile page in <PrivateSet> instead of Private Nov 30, 2023
@dac09 dac09 enabled auto-merge (squash) November 30, 2023 08:18
@dac09 dac09 merged commit 195b17a into redwoodjs:main Nov 30, 2023
32 checks passed
jtoar pushed a commit that referenced this pull request Dec 1, 2023
…ate (#9575)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
dac09 added a commit to dac09/redwood that referenced this pull request Dec 1, 2023
…ath-aliases

* 'main' of github.com:redwoodjs/redwood: (23 commits)
  Add note about base 64 encoded event body (redwoodjs#9595)
  fix(deps): update graphql-tools monorepo (redwoodjs#9609)
  fix(deps): update dependency fs-extra to v11.2.0 (redwoodjs#9606)
  fix(deps): update dependency graphql-sse to v2.4.0 (redwoodjs#9607)
  fix(deps): update docusaurus monorepo to v3.0.1 (redwoodjs#9608)
  fix(deps): update babel monorepo (redwoodjs#9596)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (redwoodjs#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (redwoodjs#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (redwoodjs#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (redwoodjs#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (redwoodjs#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (redwoodjs#9598)
  fix(deps): update storybook monorepo to v7.6.2 (redwoodjs#9597)
  RSC: Generate a route manifest (redwoodjs#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (redwoodjs#9575)
  add documentation on mocking useParams in component test (redwoodjs#9284)
  Update Typescript to 5.3.2 (redwoodjs#9589)
  RSC: Refactor build process (redwoodjs#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (redwoodjs#9579)
  ...
@Tobbe Tobbe modified the milestones: next-release-patch, next-release Dec 1, 2023
@Tobbe Tobbe mentioned this pull request Dec 1, 2023
@jtoar jtoar modified the milestones: next-release, v6.5.0 Dec 5, 2023
dac09 added a commit that referenced this pull request Jan 22, 2024
…nario-multiple-tests

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598)
  fix(deps): update storybook monorepo to v7.6.2 (#9597)
  RSC: Generate a route manifest (#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575)
  add documentation on mocking useParams in component test (#9284)
  Update Typescript to 5.3.2 (#9589)
  RSC: Refactor build process (#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579)
  fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582)
  fix: Remove "god code" typos from auth READMEs (#9583)
  Experimental Dockerfile: Fix typo in setup command (#9577)
  fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558)
  9316/update mantine setup (#9388)
  chore: clean up `RouteParams` type test structure (#9573)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants