Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Replaced deprecated <Set private> with PrivateSet within router.md #9749

Merged
merged 5 commits into from
Dec 25, 2023
Merged

docs: Replaced deprecated <Set private> with PrivateSet within router.md #9749

merged 5 commits into from
Dec 25, 2023

Conversation

suzdalnitski
Copy link
Contributor

No description provided.

@suzdalnitski suzdalnitski mentioned this pull request Dec 23, 2023
Closed
1 task
@jtoar jtoar added the release:docs This PR only updates docs label Dec 23, 2023
@jtoar jtoar added this to the next-release-patch milestone Dec 23, 2023
jtoar
jtoar reviewed Dec 23, 2023
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suzdalnitski! I can't remember if @Tobbe wanted to leave in references to Private Set till they were removed so I'll ping him for a second pair of eyes on this one. For now just added a few minor comments

docs/docs/router.md Outdated Show resolved Hide resolved
docs/docs/router.md Outdated Show resolved Hide resolved
@Tobbe
Copy link
Member

Tobbe commented Dec 25, 2023

I can't remember if @Tobbe wanted to leave in references to Private Set till they were removed

Nah, for the docs I think we can remove them all 👍

Tobbe and others added 2 commits December 25, 2023 09:10
@Tobbe @jtoar
Apply suggestions from code review
5a8d5a9 
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
@Tobbe
Merge branch 'main' into main
51e8b47
@Tobbe Tobbe enabled auto-merge (squash) December 25, 2023 08:10
@Tobbe Tobbe merged commit 909ab4e into redwoodjs:main Dec 25, 2023
31 of 32 checks passed
dac09 added a commit to dac09/redwood that referenced this pull request Dec 27, 2023
@dac09
Merge branch 'fix/enhance-error-apollo-suspense' of github.com:dac09/…
dba3868 
…redwood into fix/enhance-error-apollo-suspense

* 'fix/enhance-error-apollo-suspense' of github.com:dac09/redwood: (92 commits)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  chore(tooling): Make sure console boxen print on a new line
  chore(CI): fix publish release candidate
  feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728)
  docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742)
  Fix sshExec() errors not displaying (redwoodjs#9743)
  chore(tooling): Add missing word in release tooling output
  Update Metadata docs (redwoodjs#9744)
  chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730)
  chore(tooling): add script for getting nested dependency data (redwoodjs#9734)
  Trusted Documents docs: Proofreading corrections (redwoodjs#9737)
  ...
dac09 added a commit to dac09/redwood that referenced this pull request Dec 27, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into fix/module-p…
09e262d 
…ath-aliases

* 'main' of github.com:redwoodjs/redwood: (92 commits)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  chore(tooling): Make sure console boxen print on a new line
  chore(CI): fix publish release candidate
  feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728)
  docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742)
  Fix sshExec() errors not displaying (redwoodjs#9743)
  chore(tooling): Add missing word in release tooling output
  Update Metadata docs (redwoodjs#9744)
  chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730)
  chore(tooling): add script for getting nested dependency data (redwoodjs#9734)
  Trusted Documents docs: Proofreading corrections (redwoodjs#9737)
  ...
dac09 added a commit to dac09/redwood that referenced this pull request Dec 28, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/api-ski…
7db85c9 
…p-prebuild

* 'main' of github.com:redwoodjs/redwood: (1608 commits)
  Docker: Update to work with corepack and yarn v4 (redwoodjs#9764)
  [RFC]: useRoutePaths (redwoodjs#9755)
  Adds a note about the two commands you will use with your schema to the top of the schema file (redwoodjs#8589)
  docs: Supertokens.md: Fix typo (redwoodjs#9765)
  Fix supertokens docs & integration issues (redwoodjs#9757)
  fix(apollo): Enhance error differently for Suspense Cells (redwoodjs#9640)
  SSR smoke-test: Use <Metadata /> (redwoodjs#9763)
  chore(deps): update dependency @types/qs to v6.9.11 (redwoodjs#9761)
  chore(ci): Better error handling in detectChanges.mjs (redwoodjs#9762)
  fix(path-alias): Fix aliasing of paths using ts/jsconfig (redwoodjs#9574)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  ...
Tobbe added a commit that referenced this pull request Jan 1, 2024
@suzdalnitski @Tobbe @jtoar
docs: Replaced deprecated <Set private> with PrivateSet within router…
33e21ed 
….md (#9749)

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
@Tobbe Tobbe modified the milestones: next-release-patch, v6.6.1 Jan 1, 2024
Tobbe added a commit that referenced this pull request Jan 1, 2024
@suzdalnitski @Tobbe @jtoar
docs: Replaced deprecated <Set private> with PrivateSet within router…
0d656cf 
….md (#9749)

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar left review comments

Assignees
No one assigned
Labels
release:docs This PR only updates docs
Projects
None yet
Milestone
v6.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@suzdalnitski @Tobbe @jtoar