Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Update to work with corepack and yarn v4 #9764

Merged
merged 18 commits into from
Dec 28, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 27, 2023

With RW v6.6.0 we switched to yarn v4 (see https://github.com/redwoodjs/redwood/releases/tag/v6.6.0) and with that the steps that should be taken in our Dockerfile should have been updated. This PR does that.

More context on our forums: https://community.redwoodjs.com/t/what-is-the-procedure-to-run-the-new-docker-experimental-functionality/5640

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 27, 2023
@Tobbe Tobbe added this to the next-release-patch milestone Dec 27, 2023
@Tobbe Tobbe changed the title Docker: Remove COPY steps no longer needed with yarn v4 Docker: Update to work with corepack and yarn v4 Dec 27, 2023
@jtoar
Copy link
Contributor

jtoar commented Dec 27, 2023

Todos for @jtoar

  • update the docs
  • see about moving the RUN corepack enable instructions after apt-get?

@jtoar jtoar enabled auto-merge (squash) December 28, 2023 05:01
@jtoar jtoar merged commit 08694fb into redwoodjs:main Dec 28, 2023
32 checks passed
dac09 added a commit to dac09/redwood that referenced this pull request Dec 28, 2023
…p-prebuild

* 'main' of github.com:redwoodjs/redwood: (1608 commits)
  Docker: Update to work with corepack and yarn v4 (redwoodjs#9764)
  [RFC]: useRoutePaths (redwoodjs#9755)
  Adds a note about the two commands you will use with your schema to the top of the schema file (redwoodjs#8589)
  docs: Supertokens.md: Fix typo (redwoodjs#9765)
  Fix supertokens docs & integration issues (redwoodjs#9757)
  fix(apollo): Enhance error differently for Suspense Cells (redwoodjs#9640)
  SSR smoke-test: Use <Metadata /> (redwoodjs#9763)
  chore(deps): update dependency @types/qs to v6.9.11 (redwoodjs#9761)
  chore(ci): Better error handling in detectChanges.mjs (redwoodjs#9762)
  fix(path-alias): Fix aliasing of paths using ts/jsconfig (redwoodjs#9574)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  ...
@Tobbe Tobbe mentioned this pull request Dec 28, 2023
@Tobbe Tobbe deleted the tobbe-docker-yarn-v4 branch December 28, 2023 14:30
Tobbe added a commit that referenced this pull request Jan 1, 2024
With RW v6.6.0 we switched to yarn v4 (see
https://github.com/redwoodjs/redwood/releases/tag/v6.6.0) and with that
the steps that should be taken in our Dockerfile should have been
updated. This PR does that.

More context on our forums:
https://community.redwoodjs.com/t/what-is-the-procedure-to-run-the-new-docker-experimental-functionality/5640

---------

Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
@Tobbe Tobbe removed this from the next-release-patch milestone Jan 1, 2024
@Tobbe Tobbe added this to the v6.6.1 milestone Jan 1, 2024
Tobbe added a commit that referenced this pull request Jan 1, 2024
With RW v6.6.0 we switched to yarn v4 (see
https://github.com/redwoodjs/redwood/releases/tag/v6.6.0) and with that
the steps that should be taken in our Dockerfile should have been
updated. This PR does that.

More context on our forums:
https://community.redwoodjs.com/t/what-is-the-procedure-to-run-the-new-docker-experimental-functionality/5640

---------

Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants