fix: Wait for restore url navigation to complete before proceeding #11930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Artur Signell <artur@vaadin.com>
🦋 Changeset detectedLatest commit: 4f435a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Artur Signell <artur@vaadin.com>
Co-authored-by: Artur Signell <artur@vaadin.com>
This was referenced Aug 27, 2024
|
🤖 Hello there, We just published version Thanks! |
brophdawg11
added a commit
that referenced
this pull request
Sep 5, 2024
…11930) Co-authored-by: Artur Signell <artur@vaadin.com>
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies changes from @Artur- from #11620 but repoints to the v6 branch.
Because this relies on behavior of
historywhich JSDOM doesn't correctly implement - I'm testing this through a Remix E2E test (which will be pulled into this Repo in RR v7): remix-run/remix#9914