Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for syncronous blocker.proceed calls #9914

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Aug 26, 2024

Add a failing integration test for remix-run/react-router#11613 since it relies on specific behavior of browser history.go calls that doesn't seem to be accurately implemented in JSDOM.

This should fail initially and be fixed once we point to an experimental RR release with the fix from remix-run/react-router#11930

Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 5f34074

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor Author

Huh - weird - this integration test fails for me locally but is passing on GH actions 🤔

pnpm test:integration block --project chromium

@brophdawg11 brophdawg11 merged commit b62993a into dev Aug 27, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/sync-blocker branch August 27, 2024 13:44
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant