Prevent transitions for external links #4126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #1147
It seems like many people including myself are ending up creating custom wrapper around
<Link/>
to handle external link clicks.I think, ideally that functionality should be handled by react-router as browser has access to current and link's hosts. It turned out that it's relatively easy to compare them on click and prevent router transitions.
Hope this PR will make it and looking forward for the feedback.