Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Route propTypes, path like array of strings #5905

Closed
wants to merge 1 commit into from

Conversation

alexhtech
Copy link

According path-to-regexp path can be an array but react-router has wrong propTypes for path prop

@pshrmn
Copy link
Contributor

pshrmn commented Jan 27, 2018

Thanks for the PR! There has been discussion of supporting arrays as paths (see #5866), however, just changing the prop types isn't enough. #5889 is a more complete implementation, so I'm going to close this in favor of that.

@pshrmn pshrmn closed this Jan 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants