Added failing test check for Route and forwardRef #6384
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Route
uses the prop-type offunc
to check theComponent
prop.However, that doesn't cover all valid React components, since
React.forwardRef
returns an object as noted here.So this failing test is being added to help correct this at some point in the future.
I thought it may be nice to talk about possible solutions here as well:
isValidElementType
to add the prop type check manuallyHopefully this is helpful!