Native > Support Text as component #6451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
since six months the
react-native
implementation ofText
implementedforwardRef
. This means that, while aText
component is legit as aLink
(it implements theonPress
prop), it's not a function anymore. Instead, it will be an object with a render function.Unfortunately, the right prop type for
forwardRef
does not exists yet.This PR allows
Text
to be passed ascomponent
toLink
, withoutprop-types
warnings and maintaining a good level of safety checks.I hope you'll be ok with merging this, and thanks again for
react-router
🙌