-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): include cssBundleHref
in manifest hash
#6374
Conversation
🦋 Changeset detectedLatest commit: 6e85edb The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
return { version, entry, routes, cssBundleHref, hmr }; | ||
let fingerprintedValues = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored the code here to help people avoid the mistake of adding a new value to the manifest but forgetting to include it in the hash.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes #6369
The
cssBundleHref
value wasn't being included in the hash in the manifest file name. This means that CSS bundle changes weren't busting the manifest cache. I've also refactored the code to try to avoid this issue coming back when further changes are made to the manifest structure.