Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): include cssBundleHref in manifest hash #6374

Merged
merged 2 commits into from
May 13, 2023
Merged

fix(dev): include cssBundleHref in manifest hash #6374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dcbf3e
fix(dev): include `cssBundleHref` in manifest hash
markdalgleish May 11, 2023
6e85edb
update changeset, refactor to avoid regressions
markdalgleish May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/include-css-bundle-in-manifest-hash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Ensure CSS bundle changes result in a new manifest hash
19 changes: 17 additions & 2 deletions packages/remix-dev/compiler/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,24 @@ export async function create({
invariant(entry, `Missing output for entry point`);

optimizeRoutes(routes, entry.imports);
let version = getHash(JSON.stringify({ entry, routes })).slice(0, 8);

return { version, entry, routes, cssBundleHref, hmr };
let fingerprintedValues = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored the code here to help people avoid the mistake of adding a new value to the manifest but forgetting to include it in the hash.

entry,
routes,
cssBundleHref,
};

let version = getHash(JSON.stringify(fingerprintedValues)).slice(0, 8);

let nonFingerprintedValues = {
version,
hmr,
};

return {
...fingerprintedValues,
...nonFingerprintedValues,
};
}

export const write = async (config: RemixConfig, assetsManifest: Manifest) => {
Expand Down