Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Node.JS v22 the new target version #32068

Closed
Tracked by #25608
secustor opened this issue Oct 21, 2024 · 9 comments
Closed
Tracked by #25608

Make Node.JS v22 the new target version #32068

secustor opened this issue Oct 21, 2024 · 9 comments
Labels
breaking Breaking change, requires major version bump v39
Milestone

Comments

@secustor
Copy link
Collaborator

With the release of Node.JS v23 we are getting officially v22 as LTS.

We should use it as default target, so we keep getting back ported features.

https://nodejs.org/en/about/previous-releases

@secustor secustor mentioned this issue Oct 21, 2024
7 tasks
@rarkins
Copy link
Collaborator

rarkins commented Oct 22, 2024

What does that mean specifically? Eg do we drop support for 20? Some CI/CD systems may not have 22 support for a while.

@secustor
Copy link
Collaborator Author

Basically yes, we drop official support for v20. That being said it will still run, with a warning in the logs.

Some CI/CD systems mayr not have 22 support for a while.

Shouldn't be a problem as v22 is already out for months.

@rarkins
Copy link
Collaborator

rarkins commented Oct 22, 2024

I think we enforce nice version today don't we?

@viceice
Copy link
Member

viceice commented Oct 22, 2024

At least we should support node 22. It's scheduled for LTS in two days1. We currently only support v22

"node": "^20.15.1",

Footnotes

  1. https://github.com/nodejs/Release?tab=readme-ov-file#release-schedule

@viceice viceice added this to the v39 milestone Oct 22, 2024
@viceice viceice added the breaking Breaking change, requires major version bump label Oct 22, 2024
@rarkins rarkins added the v39 label Oct 25, 2024
@maccuaa
Copy link

maccuaa commented Oct 31, 2024

This is causing my self-hosted renovate CI job to fail:

[2024-10-31T00:34:11.526Z]  INFO: Renovate is exiting with a non-zero code due to the following logged errors
[2024-10-31T00:34:11.526Z]        "loggerErrors": [
[2024-10-31T00:34:11.526Z]          {
[2024-10-31T00:34:11.526Z]            "name": "renovate",
[2024-10-31T00:34:11.526Z]            "level": 50,
[2024-10-31T00:34:11.526Z]            "logContext": "pjpoOl8NkY0_X5Pz-KnAG",
[2024-10-31T00:34:11.526Z]            "versions": {
[2024-10-31T00:34:11.526Z]              "node": "22.11.0",
... omitted for brevity
[2024-10-31T00:34:11.526Z]            },
[2024-10-31T00:34:11.526Z]            "range": "^20.15.1",
[2024-10-31T00:34:11.526Z]            "msg": "Unsupported node environment detected. Please update your node version."
[2024-10-31T00:34:11.526Z]          }
[2024-10-31T00:34:11.526Z]        ]
...
[2024-10-31T00:12:48.735Z]        "renovateVersion": "38.138.4"

@rarkins
Copy link
Collaborator

rarkins commented Oct 31, 2024

No it's not

@maccuaa
Copy link

maccuaa commented Nov 1, 2024

That's a little disingenuous. Renovate completes "successfully" but the CI job does fail because Renovate exits with a non-zero exit code

@rarkins
Copy link
Collaborator

rarkins commented Nov 1, 2024

You are:

  • Mistakenly using Node 22 when Renovate currently supports Node 20 only, which caused your error, and
  • Wasting our time in an issue where we are planning to make Node 22 the default for our Docker images (which apparently you are not using, because if you did then you wouldn't have the problem)

rarkins added a commit that referenced this issue Nov 4, 2024
Updates Renovate's package.json>engines to add support for Node v22 LTS, and updates Renovate official Docker images to run on Node v22 instead of Node v20.

Closes #32068

BREAKING CHANGE: Renovate Docker images will now be based on Node.js v22 instead of v20
@rarkins rarkins closed this as completed in c8cb839 Nov 4, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 39.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump v39
Projects
None yet
Development

No branches or pull requests

5 participants