Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: Update to Node v22 #32182

Merged
merged 4 commits into from
Nov 1, 2024
Merged

build!: Update to Node v22 #32182

merged 4 commits into from
Nov 1, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 28, 2024

Changes

Updates Dockerfile and Actions to use Node 22

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the base branch from main to v39 October 28, 2024 16:53
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 28, 2024

# Error: Cannot find module '/home/runner/work/renovate/renovate/tools/docs/test'
#     at Function._resolveFilename (node:internal/modules/cjs/loader:1249:15)
#     at Function._load (node:internal/modules/cjs/loader:1075:27)
#     at TracingChannel.traceSync (node:diagnostics_channel:315:14)
#     at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
#     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
#     at node:internal/main/run_main_module:[36](https://github.com/renovatebot/renovate/actions/runs/11558770142/job/32171997068?pr=32182#step:7:37):49 {
#   code: 'MODULE_NOT_FOUND',
#   requireStack: []

@viceice do you know what we need to do about the .mjs file in Node v22?

@rarkins rarkins marked this pull request as draft October 28, 2024 17:04
@viceice
Copy link
Member

viceice commented Oct 28, 2024

will check later

@viceice viceice mentioned this pull request Oct 29, 2024
6 tasks
@rarkins rarkins marked this pull request as ready for review October 29, 2024 16:47
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong changes in this pr

.github/workflows/build.yml Outdated Show resolved Hide resolved
@rarkins rarkins added the breaking Breaking change, requires major version bump label Oct 31, 2024
package.json Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice October 31, 2024 06:00
@rarkins rarkins merged commit 8fdcc8a into v39 Nov 1, 2024
36 checks passed
@rarkins rarkins deleted the build/node-22 branch November 1, 2024 11:10
rarkins added a commit that referenced this pull request Nov 1, 2024
rarkins added a commit that referenced this pull request Nov 4, 2024
rarkins added a commit that referenced this pull request Nov 4, 2024
rarkins added a commit that referenced this pull request Nov 4, 2024
Updates Renovate's package.json>engines to add support for Node v22 LTS, and updates Renovate official Docker images to run on Node v22 instead of Node v20.

Closes #32068

BREAKING CHANGE: Renovate Docker images will now be based on Node.js v22 instead of v20
rarkins added a commit that referenced this pull request Nov 4, 2024
Updates Renovate's package.json>engines to add support for Node v22 LTS, and updates Renovate official Docker images to run on Node v22 instead of Node v20.

Closes #32068

BREAKING CHANGE: Renovate Docker images will now be based on Node.js v22 instead of v20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants