Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): yarnDedupeHighest for Yarn 2 #7200

Merged
merged 2 commits into from
Sep 8, 2020
Merged

fix(npm): yarnDedupeHighest for Yarn 2 #7200

merged 2 commits into from
Sep 8, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Sep 7, 2020 •
edited
Loading

Yarn 2 has introduced yarn dedupe plugin in yarnpkg/berry#1558. This PR calls it on yarnDedupeHighest post-update option.

Related: #5230.

@ylemkimon ylemkimon mentioned this pull request Sep 8, 2020
Merged
@ylemkimon
Copy link
Contributor Author

This wouldn't work unless engines.yarn is set, as getLockedVersions only detects whether it's Yarn 1 or greater. I've opened another PR #7204, as it's different scope than this PR.

/cc @viceice

@rarkins rarkins requested a review from viceice September 8, 2020 05:13
viceice
viceice reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i think we should improve the docs a little bit more

docs/usage/configuration-options.md
Comment on lines 1104 to +1105
- `yarnDedupeFewer`: Run `yarn-deduplicate --strategy fewer` after `yarn.lock` updates
- `yarnDedupeHighest`: Run `yarn-deduplicate --strategy highest` after `yarn.lock` updates
- `yarnDedupeHighest`: Run `yarn-deduplicate --strategy highest` (`yarn dedupe --strategy highest` for Yarn >=2.2.0) after `yarn.lock` updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we differentiate more bewteen yarn v1 and v2 here?

@rarkins rarkins merged commit fbd0fdd into renovatebot:master Sep 8, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JamieMagee JamieMagee mentioned this pull request Sep 9, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ylemkimon @renovate-release @viceice @rarkins