Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Make generate-rtd preserve relative directory structure #89

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Nov 10, 2020

Fix #86

This PR fixes the issue explained in #86 by preserving relative directory structure. So, if for example we have a template repository task-1 with a test at src/FiboTest.java, then the reference tests directory will get that test at RTD/task-1/src/FiboTest.java. Previously, it would end up at RTD/task-1/FiboTest.java, which caused issues if there were multiple independent tests in different directories in the same template repo.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #89 (b24b079) into master (6d8bd6e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   93.73%   93.76%   +0.02%     
==========================================
  Files           8        8              
  Lines         431      433       +2     
  Branches       66       66              
==========================================
+ Hits          404      406       +2     
  Misses         16       16              
  Partials       11       11              
Impacted Files Coverage Δ
repobee_junit4/_generate_rtd.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8bd6e...b24b079. Read the comment docs.

@slarse slarse merged commit 2dff4b0 into repobee:master Nov 10, 2020
@slarse slarse deleted the issue/86-add-support-for-multiple-independent-tests-generate-rtd branch November 29, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant